fix: leading slashes in asset generation #456
Conversation
🦋 Changeset detectedLatest commit: 257178a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: 6cb07e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with leading slashes in asset generation entry names for block assets in the webpack configuration. The fix ensures that entry names are properly normalized by removing leading slashes that could cause issues in asset bundling.
- Adds a regex replacement to remove leading slashes from generated entry names
- Implements comprehensive test coverage for the block asset entry generation functionality
- Documents the fix in a changeset for proper release tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/toolkit/config/webpack/entry.js | Adds regex to strip leading slashes from entry names after path normalization |
| packages/toolkit/config/webpack/tests/entry.js | Adds extensive test coverage for block asset handling including edge cases |
| .changeset/tough-jokes-double.md | Documents the fix for release notes |
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
I've not encountered any issues with this before but the change looks good 👍
2 participants
Related Issue/RFC: #455
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Checklist: