You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
At the moment, if a ParameterError occurs during running 21cmFAST, it will be ignored and the chain will continue, setting that set of parameters to have likelihood of -inf. As @BradGreig has pointed out, this can be dangerous because these parameters might affect the final chains.
Describe the solution you'd like
We should make it option whether to exit on these errors. The default should be to exit.
Two extra features that go along with this that we might consider:
We could count the number of times one of these errors occurs, and exit after a certain threshold number. Thus we could ignore a few bad parameter choices on the edge of the distribution, but if it keeps happening, assume something is really going wrong.
We could be a little more granular in the way we catch the errors, and let the user decide exactly which exception classes are ignored. At the moment, anything that is a subclass of ParameterError is let through. However, we could let the user specify subclasses of ParameterError (see More informative errors 21cmFAST#219) that would trigger exits/ignoring.
Is your feature request related to a problem? Please describe.
At the moment, if a
ParameterErroroccurs during running 21cmFAST, it will be ignored and the chain will continue, setting that set of parameters to have likelihood of-inf. As @BradGreig has pointed out, this can be dangerous because these parameters might affect the final chains.Describe the solution you'd like
We should make it option whether to exit on these errors. The default should be to exit.
Two extra features that go along with this that we might consider:
ParameterErroris let through. However, we could let the user specify subclasses ofParameterError(see More informative errors 21cmFAST#219) that would trigger exits/ignoring.