Fix Crash on Bot Attack

[frafol]

The server crashes because of LastLoginAPI and Parties (on Velocity), I have tried different antibots (BotSentry, nAntiBot, LimboFilter) and it only crashes if LastLoginAPI and Parties are present. Without them, the antibots work correctly.

https://youtu.be/h6ovt9t5hK4

[frafol]

https://i.imgur.com/5AkIcVk.png

[AlessioDP]

I am not sure what I can do about it, my plugin only handles player on successful login (PostLoginEvent), an anti-bot plugin may need to disconnect or cancel the event prior to that one.

The error message is related to an out of memory + the plugin needs to access the database to get the data of the player (this is done asynchronously).

I already tested the bot with some bot attacker, and I have no issue with it, no anti bots used.

[frafol]

This probably happens with LimboFilter because it connects you to an empty server, where the bots will do a "Fall Test", can you add the player to the database only if the player has left limbo?

https://github.com/Elytrium/LimboAPI is the API used by LimboFilter

[AlessioDP]

Interesting, I need to setup a test server for it.

I can add a blacklist server list where LastLoginAPI won't handle players on login, this will work right?

[frafol]

I do not know whether the drop server created by LimboAPI is a real server but you could make a test server with Limbo API + LimboFilter (or LimboAuth) and try. Sorry for my English but I am Italian.

(ora mi sono accorto che anche tu sei italiano)

[frafol]

i developer di LimboAPI mi hanno risposto questo https://i.imgur.com/0T4OJrR.png

[frafol]

Ora se LastLoginAPI aggiunge i player solo dopo essere entrati correttamente nel server e quindi usi l'evento PostLoginEvent non saprei perché loro dicono che il problema e' del tuo plugin, ma fa strano che non vadi out of memory senza LastLoginAPI e Parties

[AlessioDP]

L'out of memory c'è perchè viene contattato il database, e se spammato può succedere di andare out of memory.

Comunque mi sono accorto che in Velocity ho utilizzato il LoginEvent, invece del PostLoginEvent. Quello corretto è l'ultimo, come infatti faccio per Bungeecord. Appena riesco aggiorno i plugin, con quell'evento lì.

[quswadress]

@AlessioDP
Crash is still present on 1.7.4. The server starts thread starvation/out of memory when a bot enters (or leaves) limbo.

crash_demo.mp4