Prune unused AI provider SDKs from CLI bundle by mokagio · Pull Request #3735 · Automattic/studio

mokagio · 2026-06-09T00:57:26Z

Note

@wojtekn this JS/TS manipulation of the Electron build structure is outside my area of expertise, so it's possible the result is a big AI slop. At the same time, it does seem to address the build failure issue with the long path, so it might be a good place to start.

I'm having my agent address the Copilot comments now. Next step will be to get a different one to look over the work for possible improvements.

Related issues

Related to Fix Windows build: exclude pi-coding-agent from packaged app #3727 (alternative fix for the same Windows PathTooLongException)

How AI was used in this PR

Claude Code (Opus 4.8) diagnosed the root cause from the CI logs, verified the fix empirically against a reproduced bundle tree, and wrote the prune script and tests. I reviewed the analysis and the diff.

Proposed Changes

The Windows Squirrel maker crashes with PathTooLongException while packing the app. The real cause is @earendil-works/pi-coding-agent's transitive @mistralai/mistralai — a speakeasy-generated SDK whose ~200-char filenames, nested under pi-coding-agent/node_modules, exceed Windows' 260-char path limit. The AWS Bedrock SDK (@aws-sdk/@smithy) overflows the same way.

These are lazy, dynamically-imported pi-ai providers, and Studio only ever exposes the Anthropic and OpenAI model families (tools/common/ai/models.ts). Mistral, Bedrock and Google are therefore unreachable dead weight. This strips them from the bundled CLI during packaging, which:

fixes the path limit — 183 over-limit files → 0 (worst path drops to 236 / 260), and
reclaims tens of MB from the installer.

A missing provider degrades gracefully through pi-ai's lazy loader, so removing them is safe.

Note: this is an alternative to #3727, opened in parallel rather than stacked because that PR's commits (forge ignore, registry key, nuget.exe swap) are no-ops for this failure — the exception is thrown by Squirrel's legacy Update.exe (Path.LegacyNormalizePath), which the ignore/registry/nuget levers don't reach. See #3727 for that analysis.

Testing Instructions

npm test -- --project scripts — unit tests for the prune (removes targets in hoisted + nested locations; keeps Anthropic/OpenAI and unrelated @google/*).
Verified end-to-end against a reproduced bundle install: pruneUnusedProviders removed every offender at both the top level and under pi-coding-agent, taking over-260 files from 183 to 0.
The Windows build (make:windows-*) should now pass the Squirrel maker; macOS/Linux unaffected (and benefit from the smaller bundle).

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors? (npm run typecheck and eslint pass)

Authored by Claude (Opus 4.8) on behalf of @mokagio with approval.

The Windows Squirrel maker crashes with `PathTooLongException` while packing the app: `@mistralai/mistralai`'s ~200-char auto-generated filenames, nested under `pi-coding-agent/node_modules`, push paths past Windows' 260-char limit. The AWS Bedrock SDK (`@aws-sdk`/`@smithy`) overflows for the same reason. These are lazy, dynamically-imported `pi-ai` providers, and Studio only ever exposes the Anthropic and OpenAI families (`tools/common/ai/models.ts`), so Mistral, Bedrock and Google are unreachable dead weight. Strip them from the bundled CLI during packaging — fixing the path limit (183 over-limit files to 0, worst path 236) and reclaiming tens of MB. A missing provider degrades gracefully through pi-ai's lazy loader. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot

Pull request overview

This PR reduces the bundled CLI’s node_modules footprint during Studio packaging by pruning unused, lazily-loaded AI provider SDKs (Mistral, AWS Bedrock, Google) that are unreachable from Studio’s model registry, addressing Windows Squirrel PathTooLongException failures and shrinking installer size.

Changes:

Add a packaging-time prune utility to remove specific unused provider SDK directories from all discovered node_modules trees (hoisted and nested).
Add Vitest project configuration and unit tests for the prune behavior.
Invoke the prune step from Studio’s electron-forge prePackage hook after building the bundled CLI.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`vitest.config.ts`	Registers the new `scripts` Vitest project at the root level.
`scripts/vitest.config.ts`	Defines the `scripts` Vitest project configuration for running script unit tests.
`scripts/remove-unused-ai-providers.ts`	Implements recursive pruning of unused AI provider SDK directories from bundled CLI `node_modules`.
`scripts/remove-unused-ai-providers.test.ts`	Adds unit tests covering hoisted and nested pruning, and ensuring Anthropic/OpenAI + unrelated `@google/*` are preserved.
`apps/studio/forge.config.ts`	Calls the prune utility during `prePackage` to prevent Windows path-length issues in Squirrel packaging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mokagio · 2026-06-09T01:47:00Z

+import { readdirSync, rmSync, statSync } from 'fs';
+import { join } from 'path';


Addressed in 11f57ba1 — added an existsSync guard at the top of pruneUnusedProviders so the common missing-node_modules case short-circuits with a cheap stat instead of a thrown-and-caught ENOENT.

Posted by Claude (Opus 4.8) on behalf of @mokagio with approval.

mokagio · 2026-06-09T01:47:01Z

+			for ( const scoped of scopedEntries ) {
+				if ( scoped.isDirectory() ) {
+					pruneUnusedProviders( join( packageDir, scoped.name, 'node_modules' ) );
+				}
+			}


Addressed in 11f57ba1 — added an existsSync guard at the top of pruneUnusedProviders so the common missing-node_modules case short-circuits with a cheap stat instead of a thrown-and-caught ENOENT.

Posted by Claude (Opus 4.8) on behalf of @mokagio with approval.

mokagio · 2026-06-09T01:47:03Z

+		pruneUnusedProviders( join( packageDir, 'node_modules' ) );
+	}


Addressed in 11f57ba1 — added an existsSync guard at the top of pruneUnusedProviders so the common missing-node_modules case short-circuits with a cheap stat instead of a thrown-and-caught ENOENT.

Posted by Claude (Opus 4.8) on behalf of @mokagio with approval.

mokagio · 2026-06-09T01:58:41Z

+		try {
+			rmSync( dir, { recursive: true, force: true } );
+			console.log( `Removed ${ target } from ${ nodeModulesDir }` );
+		} catch ( e ) {
+			// Tolerate transient failures (Windows AV locks, permissions). This is a size /
+			// path-length optimization; aborting packaging over a stuck file would be worse.
+			console.warn(
+				`Could not remove ${ target } from ${ nodeModulesDir }: ${
+					e instanceof Error ? e.message : String( e )
+				}`
+			);
+		}


Addressed in 22b72d81 — pruneUnusedProviders now returns the directories it couldn't remove, and the Forge hook throws on win32 when any remain (with the offending paths), so a failed prune fails the build with context instead of degrading into a later PathTooLongException. Non-Windows platforms keep tolerating a stuck removal, where the prune is only a size optimization.

Posted by Claude (Opus 4.8) on behalf of @mokagio with approval.

wpmobilebot · 2026-06-09T01:20:30Z

📊 Performance Test Results

Comparing 7498caf vs trunk

app-size

Metric	trunk	`7498caf`	Diff	Change
App Size (Mac)	1384.36 MB	1358.07 MB	26.29 MB	🟢 -1.9%

site-editor

Metric	trunk	`7498caf`	Diff	Change
load	1642 ms	1623 ms	19 ms	⚪ 0.0%

site-startup

Metric	trunk	`7498caf`	Diff	Change
siteCreation	9046 ms	9050 ms	+4 ms	⚪ 0.0%
siteStartup	4419 ms	4415 ms	4 ms	⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

mokagio · 2026-06-09T01:41:32Z

✅ Validated on Windows CI. Triggered the dev Windows build (Buildkite #17206) and both packaging jobs passed:

🔨 Windows Dev Build — x64: passed
🔨 Windows Dev Build — arm64: passed

The x64 job cleared the exact Making a squirrel distributable step that crashed #3727, with no PathTooLongException — the prune removed the over-long provider trees before Squirrel walked the directory. All standard checks (Lint, Unit, E2E, Performance, CodeQL) are green too.

Posted by Claude (Opus 4.8) on behalf of @mokagio with approval.

Most packages have no nested `node_modules`, so the recursive walk bottomed out by letting `readdirSync` throw ENOENT and catching it — an expensive exception per miss across a large tree. Check existence up front so the common case is a cheap stat. Addresses Copilot review on #3735. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

`pruneUnusedProviders` now returns the directories it couldn't remove, and the Forge hook throws on `win32` when any remain. A leftover provider tree there resurfaces as the very `PathTooLongException` the prune prevents, so surfacing the offending paths up front beats a later opaque Squirrel crash. Other platforms still tolerate a stuck removal — it's only a size optimization there. Addresses Copilot review on #3735. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

wojtekn · 2026-06-09T08:11:32Z

Thanks for exploring that @mokagio .

I tried different approaches in #3727 and #3732, but none solved the issue. Claude was proposing the pruning way, but I kept trying to find another way.

I think it's reasonable to proceed with that approach, and in the future we could consider dropping such auto-generated dependencies, and/or migrating away from Squirrel - either by using another existing or custom maker for Forge, or better, migrating from Forge to Electron Builder.

fredrikekelund

I haven't tested this, but fundamentally, the strategy seems sound to me. I think we can compress the actual implementation a bit, though (see my inline comments)

fredrikekelund · 2026-06-09T09:22:30Z

Let's remove this test. Unit tests for a build script just doesn't make sense to me

fredrikekelund · 2026-06-09T09:24:12Z

I would inline this logic in forge.config.ts and simplify it by following the apps/cli/vite.config.prod.ts example and relying on globSync to collect the paths we want to delete, then passing those to fs.rmSync

fredrikekelund · 2026-06-09T09:25:54Z

Per my other comment, let's remove this

Copilot AI review requested due to automatic review settings June 9, 2026 00:57

mokagio self-assigned this Jun 9, 2026

Copilot started reviewing on behalf of mokagio June 9, 2026 00:57 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

mokagio requested a review from wojtekn June 9, 2026 01:42

mokagio and others added 2 commits June 9, 2026 11:44

mokagio mentioned this pull request Jun 9, 2026

Fix Windows build: exclude pi-coding-agent from packaged app #3727

Closed

3 tasks

mokagio requested review from a team and youknowriad June 9, 2026 06:50

wojtekn mentioned this pull request Jun 9, 2026

Add --omit=peer to install:bundle to prevent Windows path-too-long failures #3732

Closed

1 task

fredrikekelund reviewed Jun 9, 2026

View reviewed changes

wojtekn added 2 commits June 9, 2026 11:29

Remove build script test

894b063

Inline prune script in forge config

7498caf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prune unused AI provider SDKs from CLI bundle#3735

Prune unused AI provider SDKs from CLI bundle#3735
mokagio wants to merge 5 commits into
trunkfrom
flatten-cli-bundle-deps

mokagio commented Jun 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

mokagio Jun 9, 2026

Uh oh!

mokagio Jun 9, 2026

Uh oh!

mokagio Jun 9, 2026

Uh oh!

mokagio Jun 9, 2026

Uh oh!

wpmobilebot commented Jun 9, 2026 •

edited

Loading

Uh oh!

mokagio commented Jun 9, 2026

Uh oh!

wojtekn commented Jun 9, 2026

Uh oh!

fredrikekelund left a comment

Uh oh!

fredrikekelund Jun 9, 2026

Uh oh!

fredrikekelund Jun 9, 2026

Uh oh!

fredrikekelund Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		import { readdirSync, rmSync, statSync } from 'fs';
		import { join } from 'path';

		pruneUnusedProviders( join( packageDir, 'node_modules' ) );
		}

Conversation

mokagio commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

How AI was used in this PR

Proposed Changes

Testing Instructions

Pre-merge Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

mokagio Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

mokagio Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

mokagio Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

mokagio Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Test Results

app-size

site-editor

site-startup

Uh oh!

mokagio commented Jun 9, 2026

Uh oh!

wojtekn commented Jun 9, 2026

Uh oh!

fredrikekelund left a comment

Choose a reason for hiding this comment

Uh oh!

fredrikekelund Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

fredrikekelund Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

fredrikekelund Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mokagio commented Jun 9, 2026 •

edited

Loading

wpmobilebot commented Jun 9, 2026 •

edited

Loading