Agentic UI: Keyboard Shortcuts and Settings#3738
Conversation
a4e0429 to
eff2e73
Compare
767716a to
c8483ce
Compare
bf73f44 to
f221373
Compare
c8483ce to
38adfeb
Compare
38adfeb to
c78b950
Compare
f221373 to
48ec056
Compare
|
Code review findings (via Claude Code) that apply to this branch: 1. Cmd+N does nothing on the Desks UI (the default mode) 2. Duplicate subscriptions to 3. 4. 5. Saved-defaults resolution duplicated in settings form logic Things checked that look good: i18n coverage in the new settings view is complete, ⌘/Ctrl shortcut display handles Windows/Linux correctly with test coverage, and the settings CSS consistently uses design tokens. |
Related issues
How AI was used in this PR
AI helped split the keyboard shortcut work out of the larger
interface-improvementsbranch, keeping the branch focused and rerunning the relevant checks.Proposed Changes
Testing Instructions
npm run typechecknpm test -- apps/ui/src/lib/keyboard-shortcuts.test.ts apps/studio/src/tests/menu.test.ts apps/ui/src/components/settings-view/index.test.tsx apps/ui/src/components/site-preview/index.test.tsx apps/ui/src/ui-desks/widgets/site-shortcuts/component/index.test.tsxPre-merge Checklist