Add API to read cached post - #1561
Open
crazytonyli wants to merge 4 commits into
Open
Conversation
Replaces the per-ID select loop with a single IN query plus one batched term-relationship query, so the shared cache connection is held for two queries per batch instead of two per post. Resolves the existing TODO in read_post_full_entities_by_ids_from_db.
Collaborator
XCFramework BuildThis PR's XCFramework is available for testing. Add to your .package(url: "https://github.com/automattic/wordpress-rs", branch: "pr-build/1561")Built from 53b02ac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to use this API to read cached post in the comments screens, to show what post the comment is posted on.
I'd like to use the function signature
read_posts_by_ids_from_db -> AnyPostWithEditContext. The function name is already taken. So I changed the existing function toread_post_full_entities_by_ids_from_db -> FullEntity<AnyPostWithEditContext>.