fix: resolve lint errors causing CI failure

- Remove unnecessary type assertion in override-merger.ts
- Fix unknown type in template literals in product-publisher.ts
- Add yield* [] to generator without yield in api-product-extractor.test.ts
- Remove unused variable, fix eslint-disable directive, and rename unused param in extract-service.test.ts

Agent-Logs-Url: https://github.com/Azure/apiops-cli/sessions/e990f413-47fb-4e99-bddf-9c31ae9b68fe

Co-authored-by: EMaher <9244742+EMaher@users.noreply.github.com>

Author: Copilot

src/services/override-merger.ts

@@ -55,7 +55,7 @@ export function applyOverrides(
   const wrappedOverride = { properties: overrideValues };
 
   // Deep-merge the override into the resource JSON
-  const result = deepMerge(json, wrappedOverride as Record<string, unknown>);
+  const result = deepMerge(json, wrappedOverride);
 
   logger.debug(
     `Applied overrides to ${descriptor.type} '${descriptor.nameParts.join('/')}'`,

src/services/product-publisher.ts

@@ -125,7 +125,7 @@ async function publishProductAssociations(
       await client.putResource(context, assocDescriptor, {});
       logger.debug(`Created ${resourceType} association: ${productName}/${name}`);
     } catch (error) {
-      logger.warn(`Failed to create ${resourceType} association ${productName}/${name}: ${error}`);
+      logger.warn(`Failed to create ${resourceType} association ${productName}/${name}: ${String(error)}`);
     }
   }
 }
@@ -168,7 +168,7 @@ async function publishProductTags(
       await client.putResource(context, tagDescriptor, {});
       logger.debug(`Created ProductTag association: ${productName}/${tagName}`);
     } catch (error) {
-      logger.warn(`Failed to create ProductTag association ${productName}/${tagName}: ${error}`);
+      logger.warn(`Failed to create ProductTag association ${productName}/${tagName}: ${String(error)}`);
     }
   }
 

tests/unit/services/api-product-extractor.test.ts

@@ -502,6 +502,7 @@ describe('api-extractor', () => {
         if (type === ResourceType.GraphQLResolver) {
           throw new Error('Should not list resolvers for non-GraphQL API');
         }
+        yield* [];
       });
       client.listResources = listResourcesSpy;
 

tests/unit/services/extract-service.test.ts

@@ -299,7 +299,6 @@ describe('extract-service', () => {
       });
 
       // Handle GatewayApi requests for the gateway
-      const originalListResources = client.listResources;
       client.listResources = async function* (_ctx, type, parent?) {
         if (type === ResourceType.Gateway) {
           yield { name: 'gw-1', properties: {} };
@@ -318,7 +317,7 @@ describe('extract-service', () => {
         logLevel: LogLevel.INFO,
       };
 
-      const result = await runExtraction(client, store, config);
+      await runExtraction(client, store, config);
 
       expect(store.writeAssociation).toHaveBeenCalledWith(
         expect.anything(),
@@ -335,8 +334,7 @@ describe('extract-service', () => {
         ],
       });
 
-      // eslint-disable-next-line require-yield
-      client.listResources = async function* (_ctx, type, parent?) {
+      client.listResources = async function* (_ctx, type, _parent?) {
         if (type === ResourceType.Gateway) {
           yield { name: 'gw-1', properties: {} };
         }