Skip to content

Commit aaa0e67

Browse files
committed
test: Pin the GTK branch in form launch tests
The launch tests replaced Gtk.FileLauncher but left the real Gtk.check_version in charge, so on GTK before 4.10 they would raise or take the fallback branch. Pin check_version to a modern GTK and allow adding the attribute where it is missing. Refs BenWestgate/Bails#314
1 parent 4d65adc commit aaa0e67

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎tests/test_gui_before_you_start.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ def __init__(self, file: Any) -> None:
7878
def launch(self, _parent: object, _cancellable: object, _callback: object) -> None:
7979
opened.append(self.path)
8080

81-
monkeypatch.setattr(pages.Gtk, "FileLauncher", Launcher)
81+
monkeypatch.setattr(pages.Gtk, "FileLauncher", Launcher, raising=False)
82+
monkeypatch.setattr(pages.Gtk, "check_version", lambda *_version: None)
8283
view = Adw.NavigationView()
8384
page = pages._ready_page(view, object(), 2, 3, 16) # type: ignore[arg-type]
8485

@@ -106,7 +107,8 @@ def __init__(self, file: Any) -> None:
106107
def launch(self, _parent: object, _cancellable: object, _callback: object) -> None:
107108
pass
108109

109-
monkeypatch.setattr(pages.Gtk, "FileLauncher", Launcher)
110+
monkeypatch.setattr(pages.Gtk, "FileLauncher", Launcher, raising=False)
111+
monkeypatch.setattr(pages.Gtk, "check_version", lambda *_version: None)
110112
monkeypatch.setenv("CODEX32_FORMS_DIR", "/home/amnesia/Tor Browser/codex32 forms")
111113
view = Adw.NavigationView()
112114
page = pages._ready_page(view, object(), 2, 3, 16) # type: ignore[arg-type]

0 commit comments

Comments
 (0)