Code Refactor.

Author: Hiren.Bhalani-BTC

app/controllers/links_controller.rb

@@ -9,9 +9,9 @@ class LinksController < ApplicationController
   def index
     selected_tag = params[:tag]
     if selected_tag
-      @links = current_user_links.tagged_with(selected_tag).order(:created_at => :desc).paginate(page: page)
+      @links = current_user_links.tagged_with(selected_tag).order(created_at: :desc).paginate(page: page)
     else
-      @links = current_user_links.order(:created_at => :desc).paginate(page: page)
+      @links = current_user_links.order(created_at: :desc).paginate(page: page)
     end
     respond_to do |format|
       format.html
@@ -42,7 +42,7 @@ def new
 
   def create
     @link = Link.new(link_params.merge({ user_id: current_user.id }).except!(:tag_list))
-    current_user.tag(@link, :with => link_params[:tag_list], :on => :tags)
+    current_user.tag(@link, with: link_params[:tag_list], on: :tags)
 
     if @link.save
       redirect_to root_path
@@ -59,7 +59,7 @@ def edit
   def update
     if @link.present?
       @link.update(link_params.merge({user_id: current_user.id}).except!(:tag_list))
-      current_user.tag(@link, :with => link_params[:tag_list], :on => :tags)
+      current_user.tag(@link, with: link_params[:tag_list], on: :tags)
       flash[:success] = 'Successfully Updated!!'
       redirect_to root_path
     else
@@ -76,7 +76,7 @@ def destroy
   end
 
   def favourites
-    @links = current_user.links.where(favourite: true).order(:created_at => :desc).paginate(page: page)
+    @links = current_user.links.where(favourite: true).order(created_at: :desc).paginate(page: page)
     render 'links/index'
   end
 
@@ -93,7 +93,7 @@ def import
 
   private
     def link_params
-      params.require(:link).permit(:title, :url, :learning_status_id, :description, :category_id, :user_id,  :link_type_id, :tag_list => [])
+      params.require(:link).permit(:title, :url, :learning_status_id, :description, :category_id, :user_id,  :link_type_id, tag_list: [])
     end
 
     def assign_link

app/helpers/links_helper.rb

@@ -1,6 +1,12 @@
 module LinksHelper
   include ActsAsTaggableOn::TagsHelper
 
+  SORT_OPTIONS = ['Added On', 'Updated On', 'Recently Learned', 'Learn Count' ]
+
+  def options_for_sorting
+    options_for_select(SORT_OPTIONS)
+  end
+
   def is_favourite_link?(link)
     link.favourite
   end

app/models/link.rb

@@ -11,9 +11,9 @@ class Link < ActiveRecord::Base
   belongs_to :learning_status
   belongs_to :link_type
 
-  scope :order_by_created_at, -> { order(:created_at => :desc) }
+  scope :order_by_created_at, -> { order(created_at: :desc) }
 
-  scope :order_by_updated_at, -> { order(:updated_at => :desc) }
+  scope :order_by_updated_at, -> { order(updated_at: :desc) }
 
   def create_favourite(user_id, link_id)
     favourites.create!(user_id: user_id, link_id: link_id)
@@ -34,7 +34,7 @@ def self.find_or_create(hash, current_user)
     if @link.empty?
       without_taglist = hash.except('tag_list')
       @link = self.create! without_taglist
-      current_user.tag(@link, :with => hash['tag_list'], :on => :tags)
+      current_user.tag(@link, with: hash['tag_list'], on: :tags)
     end
   end
 end

app/views/links/index.html.erb

@@ -5,10 +5,10 @@
     <% else %>
       <div class="col-lg-8 col-md-8 col-sm-8" id="links-list">
         <%= form_tag sort_links_path, remote: true, id: 'sorting_form' do %>
-            <%= select_tag :sort_by, options_for_select(['Added On', 'Updated On', 'Recently Learned', 'Learn Count' ]), class: "select_box" %>
+          <%= select_tag :sort_by, options_for_sorting, class: "select_box" %>
         <% end %>
         <div class="links">
-          <%= render partial: 'links/links_list', locals: { links: @links}%>
+          <%= render partial: 'links/links_list', locals: { links: @links }%>
         </div>
       </div>
       <div class="col-lg-3 col-md-3 col-sm-3 showback tag-cloud-width">
@@ -23,7 +23,9 @@
   </div>
 </section>
 <script type="text/javascript">
+  $(document).ready(function(){
     $('.select_box').change(function(){
         $('#sorting_form').submit();
     });
+  });
 </script>