Skip to content

Fix subsampled size - #230

Merged
jkwashbourne-oss merged 2 commits into
ChevronETC:masterfrom
mloubout:master
Apr 17, 2026
Merged

jkwashbourne-oss merged 2 commits into
ChevronETC:masterfrom
mloubout:master

Conversation

@mloubout

Copy link
Copy Markdown
Contributor

Subsampled size is incorrect. Number of points is div(size, factor) + 1 because div(size, factor) is the number of intervals notnumber of points

@codecov

codecov Bot commented Apr 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.67%. Comparing base (29fecdc) to head (c12b994).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #230       +/-   ##
===========================================
- Coverage   97.60%   85.67%   -11.93%     
===========================================
  Files           3        3               
  Lines         792      789        -3     
===========================================
- Hits          773      676       -97     
- Misses         19      113       +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mloubout
mloubout force-pushed the master branch 3 times, most recently from a90721e to 1185bbc Compare April 16, 2026 16:49

@jkwashbourne-oss jkwashbourne-oss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jkwashbourne-oss
jkwashbourne-oss merged commit 2e7b023 into ChevronETC:master Apr 17, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants