diff --git a/Sprint-3/3-dead-code/README.md b/Sprint-3/3-dead-code/README.md index 2bfbfff81..64adbbc16 100644 --- a/Sprint-3/3-dead-code/README.md +++ b/Sprint-3/3-dead-code/README.md @@ -6,4 +6,4 @@ Here are two example of code that has not been built efficiently. Both files hav 1. Work through each `exercise` file inside this directory. 2. Delete the dead code. -3. Commit your changes and make a PR when done. +3. Commit your changes and make a PR when done. \ No newline at end of file diff --git a/Sprint-3/3-dead-code/exercise-1.js b/Sprint-3/3-dead-code/exercise-1.js index 4d09f15fa..3801dad2f 100644 --- a/Sprint-3/3-dead-code/exercise-1.js +++ b/Sprint-3/3-dead-code/exercise-1.js @@ -5,13 +5,11 @@ let testName = "Jerry"; const greeting = "hello"; function sayHello(greeting, name) { - const greetingStr = greeting + ", " + name + "!"; return `${greeting}, ${name}!`; - console.log(greetingStr); } testName = "Aman"; -const greetingMessage = sayHello(greeting, testName); +const greetingMessage = sayHello(greeting, testName); console.log(greetingMessage); // 'hello, Aman!' diff --git a/Sprint-3/3-dead-code/exercise-2.js b/Sprint-3/3-dead-code/exercise-2.js index 56d7887c4..98487f99b 100644 --- a/Sprint-3/3-dead-code/exercise-2.js +++ b/Sprint-3/3-dead-code/exercise-2.js @@ -1,13 +1,13 @@ // Remove the unused code that does not contribute to the final console log // The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. + const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; -const capitalisedPets = pets.map((pet) => pet.toUpperCase()); + const petsStartingWithH = pets.filter((pet) => pet[0] === "h"); -function logPets(petsArr) { - petsArr.forEach((pet) => console.log(pet)); -} + + function countAndCapitalisePets(petsArr) { const petCount = {}; @@ -23,6 +23,9 @@ function countAndCapitalisePets(petsArr) { return petCount; } + const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH); + console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log +