FEATURE: To do for Android

[Duecki1]

Feature Description

This is just a to do list for the Android Port. I will try my best to implement some/all of these features/fixes.

If someone wants to add something, gladly :)

• Implement Androids Filesystem (Like importing raw files, exporting)
• Add proper touch control to sliders and other interactions (masking, curves)
• Make the UI mobile compatible (Should be doable with a little bit of css for smaller screens)
• Lens correction needs work
• AI Masking needs work too
• Add Github Workflow for Android with Signed APK
• (maybe even add S-Pen Support/Android Stylus support)
• App Icon
• Make LUT selection work
• Fix safe margins
• Fix denoise slider touch
• Fix ui popups (lens correction, transform, sorting in gallery, luts)
• Fix slider accidentally touched while scrolling down
• Fix android back gesture/button to actually work
• Fix sometime not able to select any components via touch (weird bug, don't know how fix :x)
• Rotation and lens correction is very expensive on android
• set default render resolution for android
• fix accidental touches on curves and color wheels while scrolling

Additional Context

No response

Similar feature requests

• I have searched existing issues and discussions and didn't find a duplicate

[waxm134]

Just to keep the list updated: AI features and Inpainting bug should be fixed once #1090 is merged. Lensfun fix was already merged #1067
Found some more bugs on Android:

• LUT selection doesn't work
• Safe margins (source hints that those are already implemented) do not work on my side
• Denoise comparison slider has no touch control
• Not all RAW formats can be picked by the import (CR3 files do not work, I guess most other formats as well looking on how the file access is done currently)

[Duecki1]

Just to keep the list updated: AI features and Inpainting bug should be fixed once #1081 is merged. Lensfun fix was already merged #1067
Found some more bugs on Android:

• LUT selection doesn't work
• Safe margins (source hints that those are already implemented) do not work on my side
• Denoise comparison slider has no touch control
• Not all RAW formats can be picked by the import (CR3 files do not work, I guess most other formats as well looking on how the file access is done currently)

Thanks, I've updated the list :D.

What exactly do you mean by not all raw formats can be picked? Do you have a screenshot maybe?

And thanks for the PR :).

[waxm134]

Thanks for updating.

Some RAW formats like .CR3 are shown in the library import file picker but cannot be selected. I guess this is related to the MIME type filtering of the file picker. I'm currently investigating that deeper.

Also another issue I see with the current library path being on the /data partition is that there is no easy non-root way to backup the library in case I want to continue edits on desktop. My suggestion for that would be to move the library into /sdcard/Android/media/io.github.CyberTimon.RapidRAW/library and place a .nomedia so that the library will not show in the gallery. This has the advantage that the user can open/backup the library files with a file explorer. It adds no new app permissions and users can copy their RAWs directly there if they don't want to use the import function. The folder will still be deleted if the app is uninstalled, users should be made aware of this so that they can backup their library before uninstalling. I have the code changes ready for that (they are minimal) and create a PR if you agree that this makes sense.

Regarding the safe-margins there is already a plugin that we could probably use: https://github.com/saurL/tauri-plugin-safe-area-insets-css

[waxm134]

Image export currently only works from the editor panel, not from the library. Another nice feature would be to enable selection of multiple images in the library for batch export.

[Duecki1]

Thanks for updating.

Some RAW formats like .CR3 are shown in the library import file picker but cannot be selected. I guess this is related to the MIME type filtering of the file picker. I'm currently investigating that deeper.

Also another issue I see with the current library path being on the /data partition is that there is no easy non-root way to backup the library in case I want to continue edits on desktop. My suggestion for that would be to move the library into /sdcard/Android/media/io.github.CyberTimon.RapidRAW/library and place a .nomedia so that the library will not show in the gallery. This has the advantage that the user can open/backup the library files with a file explorer. It adds no new app permissions and users can copy their RAWs directly there if they don't want to use the import function. The folder will still be deleted if the app is uninstalled, users should be made aware of this so that they can backup their library before uninstalling. I have the code changes ready for that (they are minimal) and create a PR if you agree that this makes sense.

Regarding the safe-margins there is already a plugin that we could probably use: https://github.com/saurL/tauri-plugin-safe-area-insets-css

Oh yea, I never noticed the file picker not being able to import some formats. The switch to SDCard sounds good too.
The problem with the plugin is, do you know if its trustworthy? I have never worked with tauri plugins before and am not sure if they could do harm. I think with tauri v2 there's a way to handle permissions, I have just never done it.

[waxm134]

What RAW formats did you test for the file picker?

Tested the switch to /sdcard/Android/media/io.github.CyberTimon.RapidRAW/library a bit more and figured out that we need to create a hidden folder like /sdcard/Android/media/io.github.CyberTimon.RapidRAW/.library. Otherwise the Android media scanner locks access to known image formats like .jpeg if they are not added to the library by import but by copying into the library directory. Difference between .nomedia and a hidden folder seems that the media scanner doesn't even attempt to read the contents of hidden folders, while it still reads them on "normal" folders even if a .nomedia is present. Will submit the PR soon.

I don't know whether the plugin is trustworthy, but it is open source so it could be verified. From what I figured out in my research regarding this topic, the correct way of adding the top and bottom margin would be to have a kotlin plugin that gets their size from the OS and makes them available in CSS so that it can be used to style the application accordingly. This can also be implemented without the plugin, but why invent the wheel again if someone else already did.

[waxm134]

PR for the library path change: #1097 . Fixed the LUT issue as well. LUT was quite challenging without requesting more storage permissions. We should discuss whether we want to keep the "request no additional permissions" approach in future.

[Duecki1]

What RAW formats did you test for the file picker?

Tested the switch to /sdcard/Android/media/io.github.CyberTimon.RapidRAW/library a bit more and figured out that we need to create a hidden folder like /sdcard/Android/media/io.github.CyberTimon.RapidRAW/.library. Otherwise the Android media scanner locks access to known image formats like .jpeg if they are not added to the library by import but by copying into the library directory. Difference between .nomedia and a hidden folder seems that the media scanner doesn't even attempt to read the contents of hidden folders, while it still reads them on "normal" folders even if a .nomedia is present. Will submit the PR soon.

I don't know whether the plugin is trustworthy, but it is open source so it could be verified. From what I figured out in my research regarding this topic, the correct way of adding the top and bottom margin would be to have a kotlin plugin that gets their size from the OS and makes them available in CSS so that it can be used to style the application accordingly. This can also be implemented without the plugin, but why invent the wheel again if someone else already did.

I only tested the .arw file. (Sony). For implementing the plugin we would probably have to ask CyberTimon. Thanks for all the great work to make the Android Build better :D. I'm not too experienced with android builds outside of just porting. Does your pr port the existing edits from data into sdcard? Or are they just lost when updating? Thanks for fixing the LUT issue as well :). If we need permissions, we could probably request them. I don't see why requesting storage permission should be bad.

[CyberTimon]

Hey @Duecki1 and @waxm134,

Amazing progress on the Android port! Regarding the safe margins, we shouldn't need that third-party plugin... modern mobile WebViews natively support safe area insets directly through standard CSS environment variables, which is much safer and avoids the infinite loop risk mentioned in that plugin's README ;).

Thanks a lot for all your work and wishing you a nice week!
Timon

[Duecki1]

Hey @Duecki1 and @waxm134,

Amazing progress on the Android port! Regarding the safe margins, we shouldn't need that third-party plugin... modern mobile WebViews natively support safe area insets directly through standard CSS environment variables, which is much safer and avoids the infinite loop risk mentioned in that plugin's README ;).

Thanks a lot for all your work and wishing you a nice week!
Timon

Thanks, wish you a great week too! I will take a look at css environment variables 👀

[waxm134]

I only tested the .arw file. (Sony). For implementing the plugin we would probably have to ask CyberTimon. Thanks for all the great work to make the Android Build better :D. I'm not too experienced with android builds outside of just porting. Does your pr port the existing edits from data into sdcard? Or are they just lost when updating? Thanks for fixing the LUT issue as well :). If we need permissions, we could probably request them. I don't see why requesting storage permission should be bad.

No existing edits are ported with the pr. You would need to backup before via ADB with some command like ths:
adb shell run-as com.package.name cp relative/path/file.ext /sdcard adb pull /sdcard/file.ext

Regarding the safe margins, just quickly tried out this approach (option 2): tauri-apps/tauri#11475 (comment). Works well, any thoughts on that?

Have a nice week :)

[Duecki1]

I only tested the .arw file. (Sony). For implementing the plugin we would probably have to ask CyberTimon. Thanks for all the great work to make the Android Build better :D. I'm not too experienced with android builds outside of just porting. Does your pr port the existing edits from data into sdcard? Or are they just lost when updating? Thanks for fixing the LUT issue as well :). If we need permissions, we could probably request them. I don't see why requesting storage permission should be bad.

No existing edits are ported with the pr. You would need to backup before via ADB with some command like ths: adb shell run-as com.package.name cp relative/path/file.ext /sdcard adb pull /sdcard/file.ext

Regarding the safe margins, just quickly tried out this approach (option 2): tauri-apps/tauri#11475 (comment). Works well, any thoughts on that?

Have a nice week :)

The issue you found works perfectly, thanks. I have implemented it in MainActivity.
I guess if we integrate the sdcard fix in the next release it would be ok, but if we take longer many people will lose their edits.

[waxm134]

Hi @Duecki1,
with the freshly merged #1097 you can cross the LUT selection from the list :) I have some more issues to add:

• Multi-selection of images in the library is currently not possible. Would be nice to have some kind of drag-select. I implemented something similar in my earlier build using interact.js. Would be a bigger android-only change though. What do you think?
• File export from the library seems not to work

[Duecki1]

Hi @Duecki1,
with the freshly merged #1097 you can cross the LUT selection from the list :) I have some more issues to add:

• Multi-selection of images in the library is currently not possible. Would be nice to have some kind of drag-select. I implemented something similar in my earlier build using interact.js. Would be a bigger android-only change though. What do you think?
• File export from the library seems not to work

I've updated the list :D. Thanks for all the improvements.

The gallery export on vertical definitely looks interesting xD. I think we need some kind of pop up, as for tablets, maybe the export in the gallery just doesn't have the filesystem update the normal export received.

I think there should be some type of multi select, not sure how tho.