Skip to content

Commit 29669c4

Browse files
Test the metadata for counter metrics again (#16630)
1 parent 5a1c38d commit 29669c4

File tree

1 file changed

+1
-20
lines changed

1 file changed

+1
-20
lines changed

tomcat/tests/test_e2e.py

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,6 @@
77

88
from .common import TOMCAT_E2E_METRICS
99

10-
COUNTER_METRICS = [
11-
# TODO: JMXFetch is not reporting in-app type for JMX `counter` type.
12-
# Remove this exclusion list when fixed.
13-
'tomcat.bytes_rcvd',
14-
'tomcat.bytes_sent',
15-
'tomcat.error_count',
16-
'tomcat.jsp.count',
17-
'tomcat.jsp.reload_count',
18-
'tomcat.processing_time',
19-
'tomcat.request_count',
20-
'tomcat.servlet.error_count',
21-
'tomcat.servlet.processing_time',
22-
'tomcat.servlet.request_count',
23-
'tomcat.string_cache.access_count',
24-
'tomcat.string_cache.hit_count',
25-
'tomcat.web.cache.hit_count',
26-
'tomcat.web.cache.lookup_count',
27-
]
28-
2910

3011
def test_metrics(dd_agent_check, instance):
3112
aggregator = dd_agent_check(instance, rate=True)
@@ -36,7 +17,7 @@ def test_metrics(dd_agent_check, instance):
3617
aggregator.assert_metric_has_tag(metric, 'dd.internal.jmx_check_name:tomcat')
3718

3819
aggregator.assert_all_metrics_covered()
39-
aggregator.assert_metrics_using_metadata(get_metadata_metrics(), exclude=JVM_E2E_METRICS_NEW + COUNTER_METRICS)
20+
aggregator.assert_metrics_using_metadata(get_metadata_metrics(), exclude=JVM_E2E_METRICS_NEW)
4021

4122

4223
def test_service_checks(dd_agent_check, instance):

0 commit comments

Comments
 (0)