Skip to content

Commit d02410a

Browse files
committed
Pin Arrow CSV Boolean alias support for DataFusion
1 parent 86ff489 commit d02410a

4 files changed

Lines changed: 31 additions & 29 deletions

File tree

‎Cargo.lock‎

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,30 +89,30 @@ version = "55.1.0"
8989
#
9090
# See for more details: https://github.com/rust-lang/cargo/issues/11329
9191
apache-avro = { version = "0.21", default-features = false }
92-
arrow = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", features = [
92+
arrow = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", features = [
9393
"prettyprint",
9494
"chrono-tz",
9595
] }
96-
arrow-avro = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", default-features = false, features = [
96+
arrow-avro = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", default-features = false, features = [
9797
"deflate",
9898
"snappy",
9999
"zstd",
100100
"bzip2",
101101
"xz",
102102
] }
103-
arrow-buffer = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", default-features = false }
104-
arrow-data = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", default-features = false }
105-
arrow-flight = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", features = [
103+
arrow-buffer = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", default-features = false }
104+
arrow-data = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", default-features = false }
105+
arrow-flight = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", features = [
106106
"flight-sql-experimental",
107107
] }
108108
# Both codecs are required here to make sure that code paths like
109109
# file-spilling have access to all compression codecs.
110-
arrow-ipc = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", default-features = false, features = [
110+
arrow-ipc = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", default-features = false, features = [
111111
"lz4",
112112
"zstd",
113113
] }
114-
arrow-ord = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", default-features = false }
115-
arrow-schema = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", default-features = false }
114+
arrow-ord = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", default-features = false }
115+
arrow-schema = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", default-features = false }
116116
async-trait = "0.1.89"
117117
bigdecimal = "0.4.8"
118118
bytes = "1.11"
@@ -178,7 +178,7 @@ memchr = "2.8.1"
178178
num-traits = { version = "0.2" }
179179
object_store = { version = "0.13.2", default-features = false }
180180
parking_lot = "0.12"
181-
parquet = { git = "https://github.com/Embucket/arrow-rs.git", rev = "25a9c23d7b9706238b00b1288d27f036c186cd8e", default-features = false, features = [
181+
parquet = { git = "https://github.com/Embucket/arrow-rs.git", rev = "0e9c0b17db31ff260254d7dbfeecffe535675ed5", default-features = false, features = [
182182
"arrow",
183183
"async",
184184
"object_store",

‎datafusion/datasource-csv/src/file_format.rs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,8 @@ impl CsvFormat {
203203
self
204204
}
205205

206-
/// Accept exact `0` and `1` values in Boolean CSV columns.
206+
/// Accept `0`/`1` and Snowflake-style text aliases (`t`/`f`, `yes`/`no`,
207+
/// `y`/`n`, `on`/`off`) in Boolean CSV columns.
207208
pub fn with_numeric_boolean_values(mut self, allow: bool) -> Self {
208209
self.numeric_boolean_values = allow;
209210
self

‎datafusion/datasource-csv/src/source.rs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,14 @@ impl CsvSource {
116116
self
117117
}
118118

119-
/// Accept exact numeric Boolean literals (`0` and `1`) while scanning CSV.
119+
/// Accept `0`/`1` and Snowflake-style text aliases (`t`/`f`, `yes`/`no`,
120+
/// `y`/`n`, `on`/`off`) in Boolean CSV columns.
120121
pub fn with_numeric_boolean_values(mut self, allow: bool) -> Self {
121122
self.numeric_boolean_values = allow;
122123
self
123124
}
124125

125-
/// Whether exact `0` and `1` values are accepted in Boolean CSV columns.
126+
/// Whether numeric and Snowflake-style text aliases are accepted in Boolean CSV columns.
126127
pub fn numeric_boolean_values(&self) -> bool {
127128
self.numeric_boolean_values
128129
}

0 commit comments

Comments
 (0)