Clean: Allow for turning various events on/off

Author: Farhad Ghayour

core/Node.js

@@ -670,7 +670,7 @@ Node.prototype.removeComponent = function removeComponent (component) {
 *
 * @param {String} eventName the name of the event
 *
-* @return {undefined} undefined
+* @return {Node} this
 */
 Node.prototype.removeUIEvent = function removeUIEvent (eventName) {
    var UIEvents = this.getUIEvents();
@@ -685,6 +685,7 @@ Node.prototype.removeUIEvent = function removeUIEvent (eventName) {
            if (component && component.onRemoveUIEvent) component.onRemoveUIEvent(eventName);
        }
    }
+   return this;
 };
 
 /**
@@ -696,7 +697,7 @@ Node.prototype.removeUIEvent = function removeUIEvent (eventName) {
  *
  * @param {String} eventName the name of the event
  *
- * @return {undefined} undefined
+ * @return {Node} this
  */
 Node.prototype.addUIEvent = function addUIEvent (eventName) {
     var UIEvents = this.getUIEvents();
@@ -711,6 +712,7 @@ Node.prototype.addUIEvent = function addUIEvent (eventName) {
             if (component && component.onAddUIEvent) component.onAddUIEvent(eventName);
         }
     }
+    return this;
 };
 
 /**

renderers/Context.js

@@ -147,7 +147,7 @@ Context.prototype.getRootSize = function getRootSize() {
 Context.prototype.initWebGL = function initWebGL() {
     this.canvas = document.createElement('canvas');
     this._rootEl.appendChild(this.canvas);
-    this.WebGLRenderer = new WebGLRenderer(this.canvas, this._compositor, this.DOMLayerEl);
+    this.WebGLRenderer = new WebGLRenderer(this.canvas, this._compositor, this._domLayerEl);
     this.updateSize();
 };
 

webgl-renderables/Mesh.js

@@ -594,7 +594,7 @@ Mesh.prototype.onOpacityChange = function onOpacityChange (opacity) {
  *
  * @param {String} UIEvent UIEvent to be subscribed to (e.g. `click`)
  *
- * @return {undefined} undefined
+ * @return {Mesh} this
  */
 Mesh.prototype.onAddUIEvent = function onAddUIEvent(UIEvent) {
     if (this._UIEvents.indexOf(UIEvent) === -1) {
@@ -613,7 +613,7 @@ Mesh.prototype.onAddUIEvent = function onAddUIEvent(UIEvent) {
  *
  * @param {String} UIEvent UIEvent to be removed (e.g. `click`)
  *
- * @return {undefined} undefined
+ * @return {Mesh} this
  */
 Mesh.prototype.onRemoveUIEvent = function onRemoveUIEvent(UIEvent) {
     var index = this._UIEvents.indexOf(UIEvent);

webgl-renderers/WebGLRenderer.js

@@ -141,17 +141,29 @@ function WebGLRenderer(canvas, compositor, eventDiv) {
     /**
      * WebGL Picking by caputing events (e.g. 'click') using the
      * main famous HTML element for capturing events.
+     *
+     * TODO: Famous config file should contain these options for flexibility.
      */
-    var ev;
     this.listeners = {};
     this.meshIds = 0;
-    this.eventsMap = ['click', 'dblclick', 'mousewheel', 'touchstart',
-                      'keyup', 'keydown', 'mousedown', 'mouseup',
-                      'scroll', 'select', 'touchend', 'wheel'];
+    this.eventsMap = {
+        click: true,
+        dblclick: true,
+        mousewheel: false,
+        touchstart: true,
+        keyup: true,
+        keydown: true,
+        mousedown: false,
+        mouseup: false,
+        scroll: false,
+        select: false,
+        touchend: false,
+        wheel: false
+    };
 
-    var len = this.eventsMap.length;
-    for(var i = 0; i < len; i++) {
-        ev = this.eventsMap[i];
+    // If event is tracked, set the listener
+    for(var ev in this.eventsMap) {
+        if (!this.eventsMap[ev]) continue;
         this.listeners[ev] = [];
         eventDiv.addEventListener(ev, function(e) {
             _this.handleEvent(e);
@@ -232,12 +244,10 @@ WebGLRenderer.prototype.checkEvent = function checkEvent(x, y, type) {
  * @return {undefined} undefined
  */
 WebGLRenderer.prototype.subscribe = function subscribe(path, type) {
-    if (this.eventsMap.indexOf(type) === -1) {
-        return false;
+    if (this.eventsMap[type]) {
+        var mesh = this.meshRegistry[path];
+        this.listeners[type][mesh.id] = mesh;
     }
-    var mesh = this.meshRegistry[path];
-    this.listeners[type][mesh.id] = mesh;
-    return this;
 };
 
 /**
@@ -252,12 +262,10 @@ WebGLRenderer.prototype.subscribe = function subscribe(path, type) {
  * @return {undefined} undefined
  */
 WebGLRenderer.prototype.unsubscribe = function unsubscribe(path, type) {
-    if (this.eventsMap.indexOf(type) === -1) {
-        return false;
+    if (this.eventsMap[type]) {
+        var mesh = this.meshRegistry[path];
+        this.listeners[type].splice(mesh.id, 1);
     }
-    var mesh = this.meshRegistry[path];
-    this.listeners[type].splice(mesh.id, 1);
-    return this;
 };
 
 /**