From 01680da0946b31004c5078838a5ab0fad3d7fa6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Proch=C3=A1zka?= Date: Sat, 8 Feb 2020 00:41:38 +0100 Subject: [PATCH] Fix that WebRequestMonitor.tabInfo is never removed tabInfo grows over time and extension is allocating more and more memory. chrome.tabs.onRemoved.addListener is getting integer tabId, not tab object. --- .../src/module/web_request_monitor.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/omega-target-chromium-extension/src/module/web_request_monitor.coffee b/omega-target-chromium-extension/src/module/web_request_monitor.coffee index d36040502..a5b807c48 100644 --- a/omega-target-chromium-extension/src/module/web_request_monitor.coffee +++ b/omega-target-chromium-extension/src/module/web_request_monitor.coffee @@ -128,8 +128,8 @@ module.exports = class WebRequestMonitor chrome.tabs.onCreated.addListener (tab) => return unless tab.id @tabInfo[tab.id] = @_newTabInfo() - chrome.tabs.onRemoved.addListener (tab) => - delete @tabInfo[tab.id] + chrome.tabs.onRemoved.addListener (tabId) => + delete @tabInfo[tabId] chrome.tabs.onReplaced?.addListener (added, removed) => @tabInfo[added] ?= @_newTabInfo() delete @tabInfo[removed]