NPM doesn't add JSDom's dependency to package-lock.json

[cafca]

JSDOM lists request^2.88.2 as a dependency but running npm install doesn't add request to package-lock.json. I have added request as a top-level dev-dependency for now, but that's not a sustainable solution.

Steps to reproduce:

1. Uninstall my added top-level request dependency with npm uninstall request
2. Run npm install
3. Search for "request" in package-lock.json

Expected result:

request is listed in JSDOM's dependencies field.

Actual result:

JSDOM's dependencies field does not contain request.

[s-pic]

@cafca Mind me taking a look at this?

[ohrie]

I don't understand the problem correctly. Where do we need jsdom? It does not appear in the package.json. Only Jest needs it. But adds it correctly. The test run fine.

[s-pic]

Guess this regards to the lock file, not the package file

[ohrie]

Yeah, you're right. But when jsdom doesn't include request, why should be add it? ^^ Where does jsdom or out project need it, didn't find it.