Repository navigation
Commit 2af689a
authored
fix(mobile): keep the settings pull-down in the body, not the sheet (#3324)
The settings page is a modal sheet whose body is one long verticalScroll. The
sheet also followed a pull-down, so a single gesture meant both "scroll the
body" and "drag the page away": on the emulator the same pull-down moves the
sheet 305 px and dismisses the page instead of scrolling the list.
AdaptiveModalSurface now takes `draggable` (default true, so every other sheet
keeps its current behaviour) and forwards it to Material's
`sheetGesturesEnabled`. Settings opts out; its close button, the back action,
and a tap on the scrim still close the page.1 parent 2321151 commit 2af689a
3 files changed
Lines changed: 15 additions & 4 deletions
File tree
- src/apps/mobile/android/app/src
- androidTest/kotlin/com/openbitfun/mobile/app
- main/kotlin/com/openbitfun/mobile/app/ui
- common
- shell
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
50 | 56 | | |
51 | 57 | | |
52 | 58 | | |
| |||
56 | 62 | | |
57 | 63 | | |
58 | 64 | | |
| 65 | + | |
59 | 66 | | |
60 | 67 | | |
61 | 68 | | |
| |||
137 | 144 | | |
138 | 145 | | |
139 | 146 | | |
| 147 | + | |
140 | 148 | | |
141 | 149 | | |
142 | 150 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
678 | 678 | | |
679 | 679 | | |
680 | 680 | | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
681 | 685 | | |
682 | 686 | | |
683 | 687 | | |
| |||
0 commit comments