Highlight filtered words in posts

[eobet]

Describe the request

A filter triggered on some of my own posts and I don't understand why.

It would be helpful if the filtered word would be highlighted in the post itself after you reveal it.

Checks

• This follows the GNOME HIG.

[GeopJr]

It should already do so, ie:

Can I have more details about your filter? My guess is, if you set it through the web interface, you set the action as the "hide media and warn" one which was added in the last version (but I haven't gone through it yet). [1]

FWIW, this is the workflow for getting the filter name:

• if the post is marked as filtered
• go through every filter and
  • if the filter is "warn" [2]
  • get the filter name and stop
  • else go to the next filter
• return the filter name or null (you are getting null)

[1]: unfortunately when the filters were implemented, there were two actions, either "warn" or "hide completely" so the code was written around that and assumed [2] would be boolean

[eobet]

Ah, so I checked on the web and indeed one filter was set to "hide completely" so I changed that and now I do see that that filter is indeed triggered on the posts.

However, I absolutely cannot see the triggering word in question no matter how hard I try (though I have mild dyslexia), so I modified this request to be about the word highlighting.

I should also add that I do not see those posts filtered on the web, only in Tuba.

[eobet]

Ooooh, I now understand why!

The server name of one of the people mentioned in the posts contain a filtered word!

So, two things:

1. The web client apparently ignores server names when checking filters?
2. Tuba hides the server names, which made me miss this until I hit reply again.

[GeopJr]

Could you send me a screenshot of the setup (if the keywords are private, just tell me a similar one) so I can try to reproduce it?

I do think there's something I didn't take into account in tuba, because the filters are half-expected to be handled by the client and half by the server so it leaves a lot of room for mismatching with the web client.

E.g. tuba will display filter warnings even if you are the one who made the post but the web client doesn't seem to do so.

---

This is what the API gives you with a post that's filtered:

        "filtered": [
            {
                "filter": {
                    "id": "93446",
                    "title": "this is a test filter",
                    "context": [
                        "home",
                        "notifications",
                        "public",
                        "thread",
                        "account"
                    ],
                    "expires_at": null,
                    "filter_action": "warn"
                },
                "keyword_matches": [
                    "test"
                ],
                "status_matches": null
            }
        ],

As you can see:

1. the server just tells clients "this post should be filtered-out, for these reasons"
2. the client is expected to either show a warning ("warn") or hide completely from the timeline (or now, mark the media as sensitive)

---

The web client apparently ignores server names when checking filters?

so with the above in mind, I don't think the web client does any manual filter checking, since the server already tells it it's filtered out (but I'll have to confirm it!)

Tuba hides the server names, which made me miss this until I hit reply again.

Was the mention from a local user / user in the same instance as you? That's pretty much the only time the instance should be hidden and this should match the web client, otherwise it should be a bug!! (though I'm going to need more details)

[eobet]

Unless I'm misunderstanding something (which I probably am) I think you're making it out more complicated than it actually was... I was replying to a thread which included someone with a username like username@server.cat and since my filter had the word "cat" in it, Tuba filtered all replies I made from the app (again, this did not happen on the web client).