Merge pull request #1043 from GitGuardian/agateau/add-missing-dependency

Add missing dependency

Author: salome-voltz

.github/workflows/build_release_assets.yml

@@ -46,12 +46,14 @@ jobs:
   build_os_packages:
     name: Build packages
     runs-on: ${{ matrix.os }}
-    container: ${{ matrix.os == 'ubuntu-22.04' && 'rockylinux/rockylinux:8.8' || null }}
+    container: ${{ matrix.container }}
     strategy:
       fail-fast: false
       matrix:
         include:
           - os: ubuntu-22.04
+            # When building on Linux we use a container to build using an old enough version
+            container: rockylinux/rockylinux:8
           - os: windows-2022
           - os: macos-13
             arch: x86_64
@@ -84,6 +86,9 @@ jobs:
       - name: Install Linux specific dependencies
         if: matrix.os == 'ubuntu-22.04'
         run: |
+          # Install latest security updates
+          yum update -y
+
           # Install necessary packages
           yum install -y \
             python3.9 \
@@ -268,6 +273,7 @@ jobs:
           - debian:stable
           - ubuntu:latest
           - rockylinux/rockylinux:8.8
+          - rockylinux/rockylinux:9
           - opensuse/leap
           # Test a distribution with no deb or rpm support
           - clearlinux:latest
@@ -290,11 +296,11 @@ jobs:
               dpkg -i packages/*.deb
               ;;
             rockylinux*)
-              yum install -y git
+              yum install -y git-core
               rpm -i packages/*.rpm
               ;;
             opensuse*)
-              zypper install -y git
+              zypper install -y git-core
               rpm -i packages/*.rpm
               ;;
             clearlinux*)

changelog.d/20250107_114112_aurelien.gateau_add_missing_dependency.md

@@ -0,0 +1,3 @@
+### Fixed
+
+- Installing ggshield from the release RPM on EL9 failed because of a missing library. This is now fixed (#1036).

scripts/build-os-packages/nfpm.yaml

@@ -27,6 +27,13 @@ contents:
     dst: /usr/libexec/ggshield
     expand: true
 
+    # Required because our bundled Python binary still uses libcrypt.so.1, but
+    # some distributions ship with libcrypt.so.2 nowadays (see #1036).
+    # We copy libcrypt.so.1.1.0 and not libcrypt.so.1 because the later is a
+    # symlink to the former.
+  - src: /usr/lib64/libcrypt.so.1.1.0
+    dst: /usr/libexec/ggshield/_internal/libcrypt.so.1
+
   - src: README.md
     dst: /usr/share/doc/ggshield/README.md