Skip to content

Multiple control flow issues in ParameterInputDialog of Swan Implementation #47

@shashwatsridhar

Description

@shashwatsridhar

In the current implementation, the ParameterInputDialog for the Swan Implementation has three buttons - Cancel, Update Plot and Calculate. For one run of the algorithm, the Update Plot button must be clicked first in order to instantiate different Kmeans Solvers, and only then should the Calculate button be clicked. This is not clear from the design of the GUI itself, it's worth:

  • greying out the Calculate button until the Update Plot is clicked (and the Solvers are successfully calculated)

Additionally, this line should be fixed so that the chosen_solver is not looked for unless _solvers is an empty list. It should essentially read:

if not self._solvers:

This should also fix the error which is raised when Cancel is pressed in the ParameterInputDialog.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions