Skip to content

Commit db924ea

Browse files
committed
docs: cite delegated D008 decisions and clear review nits
Add a citable five-entry decision record defining the delegated RSI-master role, link the B01 rows, distinguish adopted rows from the proposed baseline, and separate the authority paragraph from the table. Remove the extra test blank line without changing behavior. Refs #414 Agent-assisted-by: Grok Bot (decision record and comment fixes) Agent-assisted-by: Claude Code / claude-fable-5-2 [effort=xhigh] (prior architecture review) Signed-off-by: GUOGUO <xwdong1998@163.com>
1 parent ac69ce4 commit db924ea

3 files changed

Lines changed: 49 additions & 4 deletions

File tree

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# D008 wave-2 ownership decision
2+
3+
Status: **Adopted for the five entries below**. Decision date: **2026-11-14 Asia/Shanghai**.
4+
5+
## Authority and scope
6+
7+
**RSI-master** names the architecture-coordination role delegated by the requesting maintainer, **Dong1017 (xinwen dong)**, to the assistant coordinating these changes. It is not an additional GitHub account, an independent reviewer, an extra approver, or a statement of legal repository ownership. Under that delegation, RSI-master makes and records the architecture choice rather than asking reviewers to select an owner.
8+
9+
This file is the citable record of the five decisions adopted under that delegation for Issues [#414](https://github.com/InferMatrixLab/InferRSI/issues/414) (B01 / PR #422) and [#413](https://github.com/InferMatrixLab/InferRSI/issues/413) (OBS / PR #425). It makes no blanket acceptance claim for the other proposed entries in [function-owners.md](function-owners.md).
10+
11+
Architecture adoption is **not** reviewer `APPROVE`, implementation acceptance, permission to merge, a gate-policy exception, or evidence that tests passed. Reviewers verify the boundary, correctness and evidence against the actual head; their independent PR decision remains separate.
12+
13+
## Benchmark sampling
14+
15+
**Adopted:** `collect_samples` belongs to **Benchmark sampling**. Benchmark owns sampling order, timing records and artifact hashes. Request transport remains the caller-injected `request(item, path)` callback; it does not become a Harness or model dependency of Benchmark.
16+
17+
Issue #414 explicitly assigns this sampling to Benchmark. The implementation is `benchmark/sampling.py`; the artifact hasher equivalence is pinned by `test_sampling_sha256_matches_the_infra_hasher`. Retaining existing protocol output does not confer ownership of UI presentation or of a caller-owned record's lifecycle.
18+
19+
## Snapshot port
20+
21+
**Adopted:** **Harness** owns the required keyword-only `snapshot(repo, exclude) -> dict` port contract; **Apps legacy** owns the binding; **infra/targets** owns the Git identity implementation. Harness has **no concrete default** for this port and does not hold a copy of the target implementation.
22+
23+
This preserves the Issue #414 split: execution facts in H, composition in Apps, implementation behind an injected port. It does not restore an H-to-infra edge. Existing compatibility disclosure for out-of-tree direct H callers remains applicable; this record does not erase it.
24+
25+
## Dashboard workflow
26+
27+
**Adopted:** `command_state`, `run_workflow` and `validation_progress` belong to **Apps views**. They project caller-loaded records into display state/counters. Their output is not a Benchmark verdict or a claim-acceptance decision.
28+
29+
## Profile records and overview
30+
31+
**Adopted:** profile attachment, factual record encoding, bounded single-trace overview generation, fixed-byte integrity checks and digest-based record reads belong to **Harness records**. UI projections and route decoration belong to **Apps views**. In particular, constructing an `events_url` for the live server is not an H responsibility.
32+
33+
This explicitly refines Issue #413's broad wording that dashboards/timelines/templates move to Apps: a persisted factual record and its bounded overview remain H record content, while the presentation and URL are Apps concerns. This is an explicit split, not a claim that the issue wording already made the distinction verbatim. Bounding events/lanes within one trace does not authorize H to rank candidates, runs or claims or to generate verdicts.
34+
35+
The route decoration is to be moved into Apps in PR #425 while preserving stored bytes, digest verification and the external view response. This record does not by itself assert that the implementation or validation has finished.
36+
37+
## Pre-profile searches
38+
39+
**Adopted:** `pre_profile_searches` belongs to **Apps views**. It combines profile facts with an existing search/ledger read model for display. Its annotations are not a new claim-evidence verdict.
40+
41+
## Integration constraints
42+
43+
The four-module dependency direction remains unchanged: Apps assembles the peers; H records do not import K or Apps. Pure knowledge context assembly belongs to K; explicit capture orchestration belongs to Apps; H retains actual delivered facts/bytes and their integrity. The #428 capture/navigation features must be preserved when OBS absorbs the newer main layout, rather than restoring an `observability` forwarding package or dropping retrieval metadata.
44+
45+
Implementation acceptance remains in the governing issues: old-run behavior and byte evidence for #414; fixed-record CLI/offline/live/trace behavior, H closure, resource packaging and disappearance of `observability/` for #413. `overall isolation_complete` remains false. None of those evidence requirements is waived here.

‎docs/contracts/function-owners.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# D008-r2 — explicit ownership for reviewed functions
22

3-
Status: **Proposed**. Author decisions under the user's delegation, based on the same-SHA Phase 2/3 source text. Audit-model suggestions are not automatically treated as accepted. Target directories and names are design; this does not claim the production code already exists, and unreviewed functions are not moved merely because of their file name. This table resolves owner choices raised in discussion; it does not make later B/Apps/Agent implementation a prerequisite for P0a/K01/H01.
3+
Status: **Proposed baseline**; individually **adopted** entries are identified by their linked decision records. This is not blanket acceptance of the table. Author decisions under the user's delegation, based on the same-SHA Phase 2/3 source text. Audit-model suggestions are not automatically treated as accepted. Target directories and names are design; this does not claim the production code already exists, and unreviewed functions are not moved merely because of their file name. This table resolves owner choices raised in discussion; it does not make later B/Apps/Agent implementation a prerequisite for P0a/K01/H01.
44

55
| Existing file / symbol | Chosen owner and target responsibility | Migration / retention constraint |
66
| --- | --- | --- |
@@ -19,8 +19,9 @@ Status: **Proposed**. Author decisions under the user's delegation, based on the
1919
| `harness/scenarios/external` `read_metric`/`validate_metric` | B semantic validation; `execute_command` and retention → H | no whole-file ownership; offline assess executes nothing |
2020
| `campaign_records` `STAGES`/claim capture/reconciliation | H records; dashboard/report presentation → Apps | first remove the `campaign_records → dashboard_data` reverse dependency; #333 is Proposed and no claim is made that a unified event envelope is accepted |
2121
| `catalog.repository_pack`/`REPO_TYPES` | D020 neutral raw-data technical leaf; target interpretation stays H | K does not expose the pack reader publicly; `infra` changes only its same-leaf import; seven K bodies/root entries/tests move together |
22-
| `benchmark/sampling` `collect_samples` (moved out of `harness/scenarios/media` by the old-run split; **ownership disposition: B sampling; RSI-master architecture decision 2026-11-14 Asia/Shanghai; independent PR review remains separate**) | B sampling: seed ordering, timing records and artifact hashes | Request transport stays with the caller's injected `request(item, path)` callback; Benchmark hashes artifacts with its own `_sha256`, pinned to `infra.artifacts.sha256` by `tests/test_legacy_run_split.py::test_sampling_sha256_matches_the_infra_hasher`, and imports no H or `infra` module. The per-group progress line on stdout is the old `run` protocol output kept for D022 and is a protocol constraint, not a presentation owner. |
23-
| `harness/runner` `snapshot` port `(repo, exclude) -> dict` (separated from the runner by the old-run split; **ownership disposition: H port contract, Apps legacy binding, `infra/targets` implementation; RSI-master architecture decision 2026-11-14 Asia/Shanghai; independent PR review remains separate**) | H owns the port and its contract; the Apps legacy composition owns the binding; `infra/targets` owns the Git identity implementation | H keeps the port required and keyword-only with no default and holds no copy of the implementation. `apps/legacy/run.py` binds `snapshot=repository_identity` for the old run and the root `execution.py` forwards it. A change of the binding owner needs its own review. Out-of-tree callers that used the removed H defaults are not covered by this row. |
22+
| `benchmark/sampling` `collect_samples` (moved out of `harness/scenarios/media` by the old-run split; **ownership disposition: B sampling; RSI-master [adopted decision, 2026-11-14 Asia/Shanghai](d008-wave2-ownership-decision.md#benchmark-sampling); independent PR review remains separate**) | B sampling: seed ordering, timing records and artifact hashes | Request transport stays with the caller's injected `request(item, path)` callback; Benchmark hashes artifacts with its own `_sha256`, pinned to `infra.artifacts.sha256` by `tests/test_legacy_run_split.py::test_sampling_sha256_matches_the_infra_hasher`, and imports no H or `infra` module. The per-group progress line on stdout is the old `run` protocol output kept for D022 and is a protocol constraint, not a presentation owner. |
23+
| `harness/runner` `snapshot` port `(repo, exclude) -> dict` (separated from the runner by the old-run split; **ownership disposition: H port contract, Apps legacy binding, `infra/targets` implementation; RSI-master [adopted decision, 2026-11-14 Asia/Shanghai](d008-wave2-ownership-decision.md#snapshot-port); independent PR review remains separate**) | H owns the port and its contract; the Apps legacy composition owns the binding; `infra/targets` owns the Git identity implementation | H keeps the port required and keyword-only with no default and holds no copy of the implementation. `apps/legacy/run.py` binds `snapshot=repository_identity` for the old run and the root `execution.py` forwards it. A change of the binding owner needs its own review. Out-of-tree callers that used the removed H defaults are not covered by this row. |
24+
2425
D008 rows are architecture decisions under the delegation recorded at the top of this file. An independent reviewer verifies the cited code, tests and dependency direction and may block on a missing adoption record; a reviewer does not choose the owner, and a PR approval is not the D008 adoption record. The architecture owner records adoption in the governed contract or decision record; the rows cite that decision record, independently of PR approval.
2526

2627
Any later split of a mixed function is accepted by real pytest/host/wheel/record comparison in the corresponding PR; none of this delays today's contract or gate-policy start. Existing external public composed entries keep their original semantics and paths per D018/D022, and an owner change cannot be used to delete an old promise.

‎tests/test_legacy_run_split.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ def test_sampling_sha256_matches_the_infra_hasher(tmp_path):
166166
assert sampling._sha256(path) == artifacts.sha256(path)
167167

168168

169-
170169
def test_harness_writer_rejects_nan_and_leaves_no_file(tmp_path):
171170
for writer in (atomic_json.atomic_write_json, artifacts.atomic_write_json):
172171
with pytest.raises(ValueError):

0 commit comments

Comments
 (0)