Performance Enhancement: Moved Automap to its Own Physics Layer#2790
Open
Vwing wants to merge 1 commit into
Open
Performance Enhancement: Moved Automap to its Own Physics Layer#2790Vwing wants to merge 1 commit into
Vwing wants to merge 1 commit into
Conversation
Moved Automap onto its own non-interacting physics layer, so we don't have to constantly enable/disable its game objects. This is a *huge* performance boost in large dungeons. Also we now destroy the generated geo immediately on transition to the outside. This could wait, before, because the geo was disabled; but now that we don't disable geo, we need to do it immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved Automap onto its own non-interacting physics layer, so we don't have to constantly enable/disable its game objects. This is a huge performance boost in large dungeons.
Also we now destroy the generated Automap geo immediately on transition to the outside. This could wait, before, because the geo was disabled; but now that we don't disable geo, we need to do it immediately.
EDIT: Ah, it was already on its own physics layer. I just set it non-interacting with other layers and removed all the then-unnecessary-and-super-unperformant enable/disable code.