-
Notifications
You must be signed in to change notification settings - Fork 95
Closed
Labels
designRequires some design before changes are madeRequires some design before changes are madeinplacefor things relating to inplace accumulationfor things relating to inplace accumulationneeds-careful-thoughtA reminder that this thing is not obviouis and care must be taken when working on itA reminder that this thing is not obviouis and care must be taken when working on it
Milestone
Description
This came up in FluxML/Zygote.jl#966, which wants to support thunks inside Zygote, not just unthunking them as they come out of rrules.
Right now rrules are not explicitly required to support thunks as the input sensitivities. We could enforce this inside ChainRulesTestUtils, and if we do, we should probably decide for 1.0?
Metadata
Metadata
Assignees
Labels
designRequires some design before changes are madeRequires some design before changes are madeinplacefor things relating to inplace accumulationfor things relating to inplace accumulationneeds-careful-thoughtA reminder that this thing is not obviouis and care must be taken when working on itA reminder that this thing is not obviouis and care must be taken when working on it