Adapt to the library-based NVPTX_LLVM_Backend_jll 23 - #3267
Merged
Merged
Conversation
NVPTX_LLVM_Backend_jll 23 ships `libnvptx` instead of `llc`; GPUCompiler 2.7 calls it in-process (JuliaGPU/GPUCompiler.jl#930). CUDA.jl only needs the compat bump; its compatibility tables already know LLVM 23. Since LLVM 23 (llvm/llvm-project#183851) only `llvm.abs` with the poison flag lowers to PTX `abs.s`, which is undefined for INT_MIN. Julia's `abs` maps INT_MIN to itself, so it now becomes `neg` + `max`; accept that in the integer abs test.
Contributor
CUDA.jl BenchmarksDetails
This comment was automatically generated by workflow using github-action-benchmark. |
maleadt
force-pushed
the
tb/jll-libraries
branch
from
September 10, 2026 11:21
ac6c10a to
304a683
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3267 +/- ##
==========================================
- Coverage 92.58% 92.56% -0.02%
==========================================
Files 188 188
Lines 16471 16471
==========================================
- Hits 15249 15246 -3
- Misses 1222 1225 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaPackaging/Yggdrasil#14727 replaced the
llc,lldandllvm-downgradeexecutables in the GPU LLVM JLLs with shared libraries exposing a small C API, moving the back-ends to LLVM 23 at the same time. JuliaGPU/GPUCompiler.jl#930 makes GPUCompiler call those libraries in-process, and bumps its compat to the new JLL majors. Since this package pins the same JLL, it needs its compat bumped in lockstep, which is what this PR does.Changes:
CUDACore:NVPTX_LLVM_Backend_jllcompat 22 → 23,GPUCompilercompat → 2.7 (the library API needs the new GPUCompiler). No code references the JLL's products; the compatibility tables already know LLVM 23.absPTX test now acceptsmax.s32/max.s64: since LLVM 23 ([SelectionDAG] Add ISD::ABS_MIN_POISON to preserve poision semantics of llvm.abs llvm/llvm-project#183851) onlyllvm.abswith the poison flag lowers to PTXabs.s, which is undefined for INT_MIN, and Julia'sabsmust map INT_MIN to itself, so it becomesneg+max.Note that NVPTX_LLVM_Backend_jll 23.1.1+0 had a bug in its FMA contraction option (fused in LLVM instead of leaving pairs contractible for ptxas); 23.1.1+1 fixes it, and compat cannot exclude the +0 build.