Remove per-launch heap allocation in CPU __run#716
Merged
vchuravy merged 5 commits intoJun 30, 2026
Conversation
vchuravy
reviewed
Jun 29, 2026
Add comment to check for thread iteration limits
Contributor
|
@simone-silvestri you need to merge on top of the remote target branch to get the buildkite pipeline work (that was fixed by #717) |
Author
|
Thanks @vchuravy, can we release a version 0.9.42? edit: Ah already done! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current
__runfunction leads to heap allocation because it boxes the args.Apparently the problem is with
lenandremthat are boxed because of being defined inside an if condition which leads to boxing of the whole args. In Oceananigans, these args are typically very large (we can get easily to MB) which in turn leads to a lot of GC getting called.MWE:
This is a backport given that KA main switched to POCL,
cc @giordano