Rename KernelIntrinsics module to KernelInterface#721
Merged
Conversation
Rename the `KernelIntrinsics` module to `KernelInterface` to better reflect that it defines the API interface backends implement. The `KI` alias is unchanged. Also rename the source/test files (`intrinsics.jl` -> `interface.jl`) and the associated test helpers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
christiangnrd
approved these changes
Jul 2, 2026
christiangnrd
left a comment
Member
There was a problem hiding this comment.
LGTM. Backend branches updated
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 62.53% 62.53%
=======================================
Files 23 23
Lines 1927 1927
=======================================
Hits 1205 1205
Misses 722 722 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KernelIntrinsicsmodule toKernelInterface, better reflecting that it defines the API interface backends implement rather than device intrinsics.KIalias is unchanged, so downstream usage (import KernelAbstractions.KernelInterface as KI) is a drop-in via the alias.intrinsics.jl->interface.jland update includes.intrinsics_testsuite->interface_testsuite, etc.) for consistency.Test plan
🤖 Generated with Claude Code