Skip to content

Rename KernelIntrinsics module to KernelInterface#721

Merged
vchuravy merged 1 commit into
mainfrom
rename-kernelintrinsics-to-kernelinterface
Jul 2, 2026
Merged

Rename KernelIntrinsics module to KernelInterface#721
vchuravy merged 1 commit into
mainfrom
rename-kernelintrinsics-to-kernelinterface

Conversation

@vchuravy

@vchuravy vchuravy commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Rename the KernelIntrinsics module to KernelInterface, better reflecting that it defines the API interface backends implement rather than device intrinsics.
  • The KI alias is unchanged, so downstream usage (import KernelAbstractions.KernelInterface as KI) is a drop-in via the alias.
  • Rename the source/test files intrinsics.jl -> interface.jl and update includes.
  • Reword the module docstring and rename the associated test helpers/testsets (intrinsics_testsuite -> interface_testsuite, etc.) for consistency.

Test plan

  • CI passes (existing interface testsuite runs under the new name)

🤖 Generated with Claude Code

Rename the `KernelIntrinsics` module to `KernelInterface` to better
reflect that it defines the API interface backends implement. The `KI`
alias is unchanged. Also rename the source/test files
(`intrinsics.jl` -> `interface.jl`) and the associated test helpers.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vchuravy
vchuravy requested a review from christiangnrd July 2, 2026 11:36
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

main 21fadf5... main / 21fadf5...
saxpy/default/Float32/1024 0.0855 ± 0.022 ms 0.087 ± 0.028 ms 0.982 ± 0.4
saxpy/default/Float32/1048576 0.495 ± 0.026 ms 0.534 ± 0.091 ms 0.927 ± 0.17
saxpy/default/Float32/16384 0.0687 ± 0.034 ms 0.0805 ± 0.038 ms 0.853 ± 0.59
saxpy/default/Float32/2048 0.0849 ± 0.028 ms 0.088 ± 0.032 ms 0.964 ± 0.47
saxpy/default/Float32/256 0.0861 ± 0.012 ms 0.0851 ± 0.027 ms 1.01 ± 0.35
saxpy/default/Float32/262144 0.182 ± 0.037 ms 0.19 ± 0.044 ms 0.955 ± 0.3
saxpy/default/Float32/32768 0.0874 ± 0.036 ms 0.0889 ± 0.038 ms 0.982 ± 0.58
saxpy/default/Float32/4096 0.0796 ± 0.03 ms 0.0813 ± 0.035 ms 0.98 ± 0.56
saxpy/default/Float32/512 0.0859 ± 0.0096 ms 0.0866 ± 0.021 ms 0.992 ± 0.26
saxpy/default/Float32/64 0.0861 ± 0.015 ms 0.0834 ± 0.024 ms 1.03 ± 0.35
saxpy/default/Float32/65536 0.0912 ± 0.033 ms 0.107 ± 0.041 ms 0.855 ± 0.45
saxpy/default/Float64/1024 0.0858 ± 0.017 ms 0.0878 ± 0.029 ms 0.977 ± 0.37
saxpy/default/Float64/1048576 0.697 ± 0.14 ms 0.699 ± 0.13 ms 0.997 ± 0.27
saxpy/default/Float64/16384 0.0677 ± 0.032 ms 0.0768 ± 0.036 ms 0.882 ± 0.59
saxpy/default/Float64/2048 0.0855 ± 0.03 ms 0.0874 ± 0.032 ms 0.979 ± 0.5
saxpy/default/Float64/256 0.0839 ± 0.025 ms 0.0861 ± 0.027 ms 0.974 ± 0.42
saxpy/default/Float64/262144 0.206 ± 0.043 ms 0.194 ± 0.037 ms 1.06 ± 0.3
saxpy/default/Float64/32768 0.0818 ± 0.034 ms 0.0914 ± 0.038 ms 0.895 ± 0.53
saxpy/default/Float64/4096 0.0773 ± 0.031 ms 0.0827 ± 0.033 ms 0.935 ± 0.53
saxpy/default/Float64/512 0.085 ± 0.022 ms 0.0875 ± 0.027 ms 0.971 ± 0.39
saxpy/default/Float64/64 0.0818 ± 0.027 ms 0.0844 ± 0.034 ms 0.969 ± 0.51
saxpy/default/Float64/65536 0.0991 ± 0.036 ms 0.108 ± 0.038 ms 0.917 ± 0.46
saxpy/static workgroup=(1024,)/Float32/1024 0.0838 ± 0.0051 ms 0.0825 ± 0.0026 ms 1.02 ± 0.07
saxpy/static workgroup=(1024,)/Float32/1048576 0.448 ± 0.032 ms 0.435 ± 0.029 ms 1.03 ± 0.1
saxpy/static workgroup=(1024,)/Float32/16384 0.0651 ± 0.033 ms 0.0677 ± 0.034 ms 0.962 ± 0.69
saxpy/static workgroup=(1024,)/Float32/2048 0.0833 ± 0.028 ms 0.0843 ± 0.031 ms 0.988 ± 0.49
saxpy/static workgroup=(1024,)/Float32/256 0.0815 ± 0.011 ms 0.0796 ± 0.011 ms 1.02 ± 0.2
saxpy/static workgroup=(1024,)/Float32/262144 0.16 ± 0.038 ms 0.175 ± 0.046 ms 0.91 ± 0.32
saxpy/static workgroup=(1024,)/Float32/32768 0.0703 ± 0.032 ms 0.0671 ± 0.029 ms 1.05 ± 0.65
saxpy/static workgroup=(1024,)/Float32/4096 0.0735 ± 0.03 ms 0.0709 ± 0.029 ms 1.04 ± 0.6
saxpy/static workgroup=(1024,)/Float32/512 0.0834 ± 0.0085 ms 0.0836 ± 0.0075 ms 0.997 ± 0.14
saxpy/static workgroup=(1024,)/Float32/64 0.0797 ± 0.019 ms 0.0789 ± 0.027 ms 1.01 ± 0.42
saxpy/static workgroup=(1024,)/Float32/65536 0.0837 ± 0.032 ms 0.0894 ± 0.034 ms 0.937 ± 0.51
saxpy/static workgroup=(1024,)/Float64/1024 0.0835 ± 0.024 ms 0.0837 ± 0.0029 ms 0.997 ± 0.29
saxpy/static workgroup=(1024,)/Float64/1048576 0.578 ± 0.12 ms 0.573 ± 0.095 ms 1.01 ± 0.26
saxpy/static workgroup=(1024,)/Float64/16384 0.065 ± 0.031 ms 0.0675 ± 0.031 ms 0.963 ± 0.64
saxpy/static workgroup=(1024,)/Float64/2048 0.084 ± 0.029 ms 0.0841 ± 0.034 ms 0.999 ± 0.53
saxpy/static workgroup=(1024,)/Float64/256 0.0806 ± 0.029 ms 0.0826 ± 0.019 ms 0.976 ± 0.42
saxpy/static workgroup=(1024,)/Float64/262144 0.193 ± 0.045 ms 0.197 ± 0.05 ms 0.98 ± 0.34
saxpy/static workgroup=(1024,)/Float64/32768 0.0758 ± 0.031 ms 0.0777 ± 0.031 ms 0.976 ± 0.56
saxpy/static workgroup=(1024,)/Float64/4096 0.0764 ± 0.031 ms 0.0789 ± 0.033 ms 0.968 ± 0.56
saxpy/static workgroup=(1024,)/Float64/512 0.0826 ± 0.01 ms 0.0797 ± 0.037 ms 1.04 ± 0.5
saxpy/static workgroup=(1024,)/Float64/64 0.0789 ± 0.031 ms 0.0789 ± 0.034 ms 1 ± 0.58
saxpy/static workgroup=(1024,)/Float64/65536 0.0956 ± 0.033 ms 0.0981 ± 0.035 ms 0.975 ± 0.48
time_to_load 1.15 ± 0.038 s 1.13 ± 0.0075 s 1.02 ± 0.034

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@christiangnrd christiangnrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Backend branches updated

@vchuravy
vchuravy merged commit 5ab7d7f into main Jul 2, 2026
37 of 48 checks passed
@vchuravy
vchuravy deleted the rename-kernelintrinsics-to-kernelinterface branch July 2, 2026 12:19
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.53%. Comparing base (9dcc818) to head (21fadf5).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   62.53%   62.53%           
=======================================
  Files          23       23           
  Lines        1927     1927           
=======================================
  Hits         1205     1205           
  Misses        722      722           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants