Repository navigation
streamline create_and_fill helper function in tests - #353
Merged
Merged
Conversation
Member
|
the only real issue seems to be |
Contributor
Author
|
my bad, filter on namedtuples was added in 1.11 |
lazarusA
approved these changes
Oct 1, 2026
Contributor
Author
|
I'm quite tempted to put these repeated calls to the same function for 500 lines in some nested loops, but it's probably nice to see the line number when there are test failures |
Member
Do it. As I see it, that is only the testdata generation and I would be more interested in the actual line numbers for the tests and not the test data generation. |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
|
I think to some degree, something similar could be done to https://github.com/JuliaIO/Zarr.jl/blob/main/Zarr/test/v3_julia.jl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace repeated
if x !== nothingchecks with a singlefilter(!isnothing, nt)