Skip to content

Create docs site favicon#347

Merged
devmotion merged 2 commits into
JuliaStats:masterfrom
abhro:favicon
Nov 20, 2025
Merged

Create docs site favicon#347
devmotion merged 2 commits into
JuliaStats:masterfrom
abhro:favicon

Conversation

@abhro

@abhro abhro commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Favicon created with
```sh
$ convert logo.png -scale 128 favicon.ico
```
using ImageMagick

@devmotion devmotion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the logo of the JuliaStats org, isn't? I don't think it's really neccessary or useful but I'm fine with it in general. However, I thinknit seems a bit strange to sdd the org's icon to every repo - could we upload it in a single place sonewhere and then access it from every repo?

@abhro

abhro commented Aug 17, 2025

Copy link
Copy Markdown
Contributor Author

Admittedly, this is a very minor improvement. It mostly helps bookmarks and open tabs in web browsers and immediately creates the association that it's one of the JuliaStats pages when reading documentation. I've also found that in other organizations, the org logo is used as the default fallback unless the repository itself has a different logo. As for the shared access to the organization logo for all repos, there probably is a way to facilitate that, but I'm not skillful enough to have found/developed it 😅

@devmotion devmotion enabled auto-merge (squash) August 17, 2025 17:39
auto-merge was automatically disabled November 20, 2025 13:47

Head branch was pushed to by a user without write access

@codecov-commenter

codecov-commenter commented Nov 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.55%. Comparing base (9b992ee) to head (a361197).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          29       29           
  Lines        1835     1835           
=======================================
  Hits         1735     1735           
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion devmotion merged commit 924c191 into JuliaStats:master Nov 20, 2025
11 checks passed
@abhro abhro deleted the favicon branch November 20, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants