Merge pull request #514 from KhiopsML/fix-unhappy-paths-detection-windows

Add the detection of a python virtual environment when searching for unhappy installation paths under Windows

Author: tramora

.github/workflows/tests.yml

@@ -276,9 +276,21 @@ jobs:
           python -m pip install setuptools
           python scripts/extract_dependencies_from_pyproject_toml.py -f "pyproject.toml" -s "\n"  > requires.txt
 
-          # Install the Python requirements
+          # Install the Python requirements outside a python venv
           Get-Content .\requires.txt `
             | ForEach-Object {python -m pip install $_.toString()}
+
+          # Create and activate a python venv
+          python -m venv khiops-windows-venv
+          khiops-windows-venv\Scripts\Activate.ps1
+
+          # Install the Python requirements inside a venv
+          # The venv python executable is used here
+          Get-Content .\requires.txt `
+            | ForEach-Object {khiops-windows-venv\Scripts\python -m pip install $_.toString()}
+
+          # Deactivate the python venv
+          deactivate
           Remove-Item -force requires.txt
       - name: Setup and Install Test Requirements
         run: python -m pip install -r test-requirements.txt
@@ -323,6 +335,22 @@ jobs:
 
           # Execute Khiops Coclustering sample (train and deploy model)
           Invoke-Expression -Command "$Python -m khiops.samples.samples -i deploy_coclustering -e"
+
+          # Install khiops-python in the python venv using the sources          
+          # The venv python executable is used here 
+          Invoke-Expression -Command "khiops-windows-venv\Scripts\python -m pip install ."
+          # Change directory to avoid using the cloned khiops-python
+          Invoke-Expression -Command "cd khiops-windows-venv\"
+
+          # Print status
+          # The venv python executable is used here
+          Invoke-Expression -Command "Scripts\python -c 'import sys; import khiops.core as kh; return_code = kh.get_runner().print_status(); sys.exit(return_code)'"
+
+          # The installation status MUST not fail                    
+          if ($LASTEXITCODE -ne 0) {
+            Write-Host "::error::Status error: khiops-python installation status check MUST NOT fail"
+            exit 1
+          }
   check-khiops-integration-on-linux:
     strategy:
       fail-fast: false

doc/requirements.txt

@@ -5,5 +5,5 @@ nbconvert==6.4.4
 nbformat==5.3.0
 numpydoc>=1.5.0
 pandas>=0.25.3
-scikit-learn>=0.22.2
+scikit-learn>=0.22.2,<=1.7.2
 sphinx-copybutton>=0.5.0

khiops/core/internals/runner.py

@@ -1218,9 +1218,15 @@ def _detect_library_installation_incompatibilities(self, library_root_dir):
                     if (
                         platform.system() == "Windows"
                         and
-                        # Under Windows, python is not in a bin/ folder
-                        # for conda-based installations
-                        str(Path(sys.executable).parents[0]) != base_dir
+                        # Under Windows, there are two cases :
+                        (
+                            # for conda-based installations python is inside 'base_dir'
+                            str(Path(sys.executable).parents[0]) != base_dir
+                            and
+                            # for 'binary+pip' installations (within a virtual env)
+                            # python is inside 'base_dir'/Scripts
+                            str(Path(sys.executable).parents[1]) != base_dir
+                        )
                         # Under Linux or MacOS a bin/ folder exists
                         or str(Path(sys.executable).parents[1]) != base_dir
                     ):

pyproject.toml

@@ -105,16 +105,16 @@ classifiers = [
 requires-python = ">=3.8"
 dependencies = [
     "pandas>=0.25.3",
-    "scikit-learn>=0.22.2",
+    # do not use the latest version, to avoid undesired breaking changes
+    "scikit-learn>=0.22.2,<=1.7.2",
 ]
 
 [project.urls]
 Homepage = "https://khiops.org"
 
 [project.optional-dependencies]
 s3 = [
-    # do not necessarily use the latest version, to avoid undesired breaking
-    # changes
+    # do not use the latest version, to avoid undesired breaking changes
     "boto3>=1.17.39,<=1.35.69",
 ]
 gcs = [