improve performance by reducing the range to search for the playback information in memory on windows, add reconnect timeout for windows, version 1.1.9

Author: LabyStudio

README.md

@@ -23,7 +23,7 @@ repositories {
 }
 
 dependencies {
-    implementation 'com.github.LabyStudio:java-spotify-api:1.1.8:all'
+    implementation 'com.github.LabyStudio:java-spotify-api:1.1.9:all'
 }
 ```
 

build.gradle

@@ -4,7 +4,7 @@ plugins {
 }
 
 group 'de.labystudio'
-version '1.1.8'
+version '1.1.9'
 
 compileJava {
     sourceCompatibility = '1.8'

src/main/java/de/labystudio/spotifyapi/platform/windows/WinSpotifyAPI.java

@@ -20,6 +20,8 @@
  */
 public class WinSpotifyAPI extends AbstractTickSpotifyAPI {
 
+    private static final long RECONNECT_TIMEOUT = 1000 * 10L;
+
     private SpotifyProcess process;
 
     private Track currentTrack;
@@ -31,13 +33,22 @@ public class WinSpotifyAPI extends AbstractTickSpotifyAPI {
     private long lastAccessorPosition = -1;
     private long lastTimeSynced;
 
+    private long lastTimeDisconnected = -1;
+
     /**
      * Updates the current track, position and playback state.
      * If the process is not connected, it will try to connect to the Spotify process.
      */
     protected void onTick() {
         try {
             if (!this.isConnected()) {
+                // Check if we passed the reconnect timeout
+                long timePassedSinceLastDisconnect = System.currentTimeMillis() - this.lastTimeDisconnected;
+                if (timePassedSinceLastDisconnect < RECONNECT_TIMEOUT) {
+                    return;
+                }
+
+                // Connect
                 this.process = new SpotifyProcess();
 
                 // Fire on connect
@@ -104,6 +115,7 @@ protected void onTick() {
             // Fire on disconnect
             this.listeners.forEach(listener -> listener.onDisconnect(exception));
             this.process = null;
+            this.lastTimeDisconnected = System.currentTimeMillis();
         }
     }
 

src/main/java/de/labystudio/spotifyapi/platform/windows/api/WinProcess.java

@@ -294,7 +294,11 @@ public Map<String, Psapi.ModuleInfo> getModules() {
     public long getFirstModuleAddress() {
         long minAddress = Long.MAX_VALUE;
         for (Map.Entry<String, Psapi.ModuleInfo> module : this.getModules().entrySet()) {
-            minAddress = Math.min(minAddress, module.getValue().getBaseOfDll());
+            long baseOfDll = module.getValue().getBaseOfDll();
+            if (baseOfDll <= 0) {
+                continue;
+            }
+            minAddress = Math.min(minAddress, baseOfDll);
         }
         return minAddress;
     }

src/main/java/de/labystudio/spotifyapi/platform/windows/api/spotify/SpotifyProcess.java

@@ -41,13 +41,13 @@ public SpotifyProcess() {
 
         long timeScanStart = System.currentTimeMillis();
 
-        Psapi.ModuleInfo chromeElf = this.getModuleInfo("chrome_elf.dll");
-        if (chromeElf == null) {
+        Psapi.ModuleInfo chromeElfModule = this.getModuleInfo("chrome_elf.dll");
+        if (chromeElfModule == null) {
             throw new IllegalStateException("Could not find chrome_elf.dll module");
         }
 
         // Find address of track id (Located in the chrome_elf.dll module)
-        long chromeElfAddress = chromeElf.getBaseOfDll();
+        long chromeElfAddress = chromeElfModule.getBaseOfDll();
         this.addressTrackId = this.findAddressOfText(chromeElfAddress, PREFIX_SPOTIFY_TRACK, 0);
 
         if (this.addressTrackId == -1 || !this.isTrackIdValid(this.getTrackId())) {
@@ -57,13 +57,19 @@ public SpotifyProcess() {
             System.out.println("Found track id address: " + Long.toHexString(this.addressTrackId));
         }
 
+        // Get address range to search for playback
+        Psapi.ModuleInfo spotifyExeModule = this.getModuleInfo("Spotify.exe");
+        Psapi.ModuleInfo libCefModule = this.getModuleInfo("libcef.dll");
+        long minAddress = spotifyExeModule == null ? 0 : spotifyExeModule.getBaseOfDll();
+        long maxAddress = spotifyExeModule == null ? this.addressTrackId : libCefModule.getBaseOfDll();
+
         // Check if the song is currently playing using the title bar
         boolean isPlaying = this.isPlayingUsingTitle();
 
         // Find addresses of playback states
         this.addressPlayBack = this.findInMemory(
-                0,
-                this.addressTrackId,
+                minAddress,
+                maxAddress,
                 PREFIX_CONTEXT,
                 (address, index) -> {
                     PlaybackAccessor accessor = new PlaybackAccessor(this, address);