Don't include all types in Vm children

The parent class includes all classes (that are VMs)
No reason to include a `type` query.

Before
======

```
vmdb(dev)> puts Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."type" IN ('Vm', 'VmServer',
  'ManageIQ::Providers::PhysicalInfraManager::Vm', 'ManageIQ::Providers::InfraManager::Vm',
  'ManageIQ::Providers::CloudManager::Vm', 'ManageIQ::Providers::CiscoIntersight::PhysicalInfraManager::Vm',
  'ManageIQ::Providers::Vmware::InfraManager::Vm', 'ManageIQ::Providers::Ovirt::InfraManager::Vm',
  'ManageIQ::Providers::Nutanix::InfraManager::Vm', 'ManageIQ::Providers::Kubevirt::InfraManager::Vm',
  'ManageIQ::Providers::IbmPowerHmc::InfraManager::Vm', 'ManageIQ::Providers::Redhat::InfraManager::Vm',
  'ManageIQ::Providers::Openshift::InfraManager::Vm', 'ManageIQ::Providers::IbmPowerHmc::InfraManager::Vios',
  'ManageIQ::Providers::IbmPowerHmc::InfraManager::Lpar', 'ManageIQ::Providers::Vmware::CloudManager::Vm',
  'ManageIQ::Providers::OracleCloud::CloudManager::Vm', 'ManageIQ::Providers::Openstack::CloudManager::Vm',
  'ManageIQ::Providers::IbmCloud::VPC::CloudManager::Vm', 'ManageIQ::Providers::IbmCloud::PowerVirtualServers::CloudManager::Vm',
  'ManageIQ::Providers::Google::CloudManager::Vm', 'ManageIQ::Providers::AzureStack::CloudManager::Vm',
  'ManageIQ::Providers::Azure::CloudManager::Vm', 'ManageIQ::Providers::Amazon::CloudManager::Vm',
  'ManageIQ::Providers::IbmPowerVc::CloudManager::Vm', 'ManageIQ::Providers::IbmCic::CloudManager::Vm')
  AND "vms"."template" = FALSE
=> nil
vmdb(dev)> puts ManageIQ::Providers::Vmware::InfraManager::Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."type" = 'ManageIQ::Providers::Vmware::InfraManager::Vm'
  AND "vms"."template" = FALSE
```

After
=====

```
vmdb(dev)> puts Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."template" = FALSE
=> nil
vmdb(dev)> puts ManageIQ::Providers::Vmware::InfraManager::Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."type" = 'ManageIQ::Providers::Vmware::InfraManager::Vm'
  AND "vms"."template" = FALSE
```

Author: kbrock

app/models/miq_template.rb

@@ -16,6 +16,11 @@ def self.base_model
     MiqTemplate
   end
 
+  # Don't tack on `type IN []` query for the top level classes (default scope already filters out the vms)
+  def self.finder_needs_type_condition?
+    self != base_model
+  end
+
   def self.corresponding_model
     module_parent::Vm
   end

app/models/vm.rb

@@ -14,6 +14,11 @@ def self.base_model
     Vm
   end
 
+  # Don't tack on `type IN []` query for the top level classes (default scope already filters out the templates)
+  def self.finder_needs_type_condition?
+   self < base_model
+  end
+
   def self.corresponding_model
     if self == Vm
       MiqTemplate

spec/models/miq_report/generator_spec.rb

@@ -73,10 +73,12 @@
         FactoryBot.create(:template) # filtered out by report.where_clause
         vm = FactoryBot.create(:vm, :vendor => "redhat")
 
+        expect(vm.type).to match(/Vm/)
+
         rpt = FactoryBot.create(
           :miq_report,
           :db           => "VmOrTemplate",
-          :where_clause => ["vms.type = ?", "Vm"],
+          :where_clause => ["vms.type = ?", vm.type],
           :col_order    => %w[id name host.name vendor]
         )
         rpt.generate_table(:userid => @user.userid, :where_clause => {"vms.vendor" => "redhat"})