feat: currentCurrency added to AssetsController state#7991
Open
feat: currentCurrency added to AssetsController state#7991
Conversation
bergarces
commented
Feb 19, 2026
Contributor
Author
There was a problem hiding this comment.
Currency is already included as part of the query key for cache purposes, so no changes needed in the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The state for
currentCurrencyis currently saved inCurrencyRateController. Since that controller is being deprecated, and we need that piece of state to be stored somewhere, it's being moved to the controller that will replace it.This PR also ensures that
PriceDataSourcegets updated with the existing currency instead of just being set up at constructor level.References
Checklist
Note
Medium Risk
Introduces new persisted state and changes the
PriceDataSourceOptionsAPI, which may require consumer updates and could affect price-refresh behavior if miswired.Overview
Adds a persisted
selectedCurrency(ISO 4217, defaultusd) toAssetsControllerplussetSelectedCurrency, which updates state and triggers a one-offgetAssetsrefresh forpricedata.Refactors
PriceDataSourceto take a requiredgetSelectedCurrency()callback (replacing the staticcurrencyoption) so price fetches always use the latest currency, and updates unit tests/changelog accordingly.Written by Cursor Bugbot for commit 999bdba. This will update automatically on new commits. Configure here.