From 41f847250ea9f521d55347a2eaa12e937f26a026 Mon Sep 17 00:00:00 2001 From: Stanley Yuen <102275989+stanleyyconsensys@users.noreply.github.com> Date: Fri, 7 Aug 2026 21:06:35 +0800 Subject: [PATCH 1/3] fix: always show memo --- packages/snap/locales/en.json | 12 ++++++++++++ packages/snap/locales/es.json | 12 ++++++++++++ .../ConfirmSignTransaction.tsx | 16 ++++++++-------- 3 files changed, 32 insertions(+), 8 deletions(-) diff --git a/packages/snap/locales/en.json b/packages/snap/locales/en.json index 7dc7139..74598aa 100644 --- a/packages/snap/locales/en.json +++ b/packages/snap/locales/en.json @@ -16,6 +16,15 @@ "confirmation.estimatedChanges.receive": { "message": "You receive" }, + "confirmation.estimatedChanges.sendOther": { + "message": "Send" + }, + "confirmation.estimatedChanges.receiveOther": { + "message": "Receive" + }, + "confirmation.estimatedChanges.account": { + "message": "Account" + }, "confirmation.origin": { "message": "Request from" }, @@ -100,6 +109,9 @@ "confirmation.memo": { "message": "Memo" }, + "confirmation.memo.none": { + "message": "None" + }, "confirmation.asset": { "message": "Asset" }, diff --git a/packages/snap/locales/es.json b/packages/snap/locales/es.json index 605a271..c9e9783 100644 --- a/packages/snap/locales/es.json +++ b/packages/snap/locales/es.json @@ -16,6 +16,15 @@ "confirmation.estimatedChanges.receive": { "message": "You receive" }, + "confirmation.estimatedChanges.sendOther": { + "message": "Send" + }, + "confirmation.estimatedChanges.receiveOther": { + "message": "Receive" + }, + "confirmation.estimatedChanges.account": { + "message": "Account" + }, "confirmation.origin": { "message": "Request from" }, @@ -100,6 +109,9 @@ "confirmation.memo": { "message": "Memo" }, + "confirmation.memo.none": { + "message": "None" + }, "confirmation.asset": { "message": "Asset" }, diff --git a/packages/snap/src/ui/confirmation/views/ConfirmSignTransaction/ConfirmSignTransaction.tsx b/packages/snap/src/ui/confirmation/views/ConfirmSignTransaction/ConfirmSignTransaction.tsx index dcc9521..b197188 100644 --- a/packages/snap/src/ui/confirmation/views/ConfirmSignTransaction/ConfirmSignTransaction.tsx +++ b/packages/snap/src/ui/confirmation/views/ConfirmSignTransaction/ConfirmSignTransaction.tsx @@ -279,14 +279,14 @@ export const ConfirmSignTransaction = ({ price={feePrice} tokenPricesFetchStatus={tokenPricesFetchStatus} /> - {[readableTransaction.memo].filter(Boolean).map((memo) => ( - - - {t('confirmation.memo')} - - {memo} - - ))} + + + {t('confirmation.memo')} + + + {readableTransaction.memo ?? t('confirmation.memo.none')} + + {/* Authorizations */} From 447d1e5d9d0968465eb635e0323fbbb8facb8a79 Mon Sep 17 00:00:00 2001 From: Stanley Yuen <102275989+stanleyyconsensys@users.noreply.github.com> Date: Fri, 7 Aug 2026 21:07:18 +0800 Subject: [PATCH 2/3] chore: add message json --- packages/snap/messages.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/snap/messages.json b/packages/snap/messages.json index 951f97e..f8aff97 100644 --- a/packages/snap/messages.json +++ b/packages/snap/messages.json @@ -14,6 +14,15 @@ "confirmation.estimatedChanges.receive": { "message": "You receive" }, + "confirmation.estimatedChanges.sendOther": { + "message": "Send" + }, + "confirmation.estimatedChanges.receiveOther": { + "message": "Receive" + }, + "confirmation.estimatedChanges.account": { + "message": "Account" + }, "confirmation.origin": { "message": "Request from" }, @@ -98,6 +107,9 @@ "confirmation.memo": { "message": "Memo" }, + "confirmation.memo.none": { + "message": "None" + }, "confirmation.asset": { "message": "Asset" }, From f2814ff167edcc8e124c556369104356d7700c57 Mon Sep 17 00:00:00 2001 From: Stanley Yuen <102275989+stanleyyconsensys@users.noreply.github.com> Date: Fri, 7 Aug 2026 21:09:43 +0800 Subject: [PATCH 3/3] chore: remove unuse locate --- packages/snap/locales/en.json | 9 --------- packages/snap/locales/es.json | 9 --------- packages/snap/messages.json | 9 --------- 3 files changed, 27 deletions(-) diff --git a/packages/snap/locales/en.json b/packages/snap/locales/en.json index 74598aa..608a956 100644 --- a/packages/snap/locales/en.json +++ b/packages/snap/locales/en.json @@ -16,15 +16,6 @@ "confirmation.estimatedChanges.receive": { "message": "You receive" }, - "confirmation.estimatedChanges.sendOther": { - "message": "Send" - }, - "confirmation.estimatedChanges.receiveOther": { - "message": "Receive" - }, - "confirmation.estimatedChanges.account": { - "message": "Account" - }, "confirmation.origin": { "message": "Request from" }, diff --git a/packages/snap/locales/es.json b/packages/snap/locales/es.json index c9e9783..bbb11a8 100644 --- a/packages/snap/locales/es.json +++ b/packages/snap/locales/es.json @@ -16,15 +16,6 @@ "confirmation.estimatedChanges.receive": { "message": "You receive" }, - "confirmation.estimatedChanges.sendOther": { - "message": "Send" - }, - "confirmation.estimatedChanges.receiveOther": { - "message": "Receive" - }, - "confirmation.estimatedChanges.account": { - "message": "Account" - }, "confirmation.origin": { "message": "Request from" }, diff --git a/packages/snap/messages.json b/packages/snap/messages.json index f8aff97..b73da43 100644 --- a/packages/snap/messages.json +++ b/packages/snap/messages.json @@ -14,15 +14,6 @@ "confirmation.estimatedChanges.receive": { "message": "You receive" }, - "confirmation.estimatedChanges.sendOther": { - "message": "Send" - }, - "confirmation.estimatedChanges.receiveOther": { - "message": "Receive" - }, - "confirmation.estimatedChanges.account": { - "message": "Account" - }, "confirmation.origin": { "message": "Request from" },