From 7ba2f79bf98b40ffb1c182bbef01defd55a22374 Mon Sep 17 00:00:00 2001 From: Gabryel-lima Date: Wed, 20 May 2026 15:11:06 -0300 Subject: [PATCH 1/2] Implement osPfsInit and osPfsIsPlug functions with error handling --- librecomp/src/pak.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/librecomp/src/pak.cpp b/librecomp/src/pak.cpp index 0be1513e..be3afe73 100644 --- a/librecomp/src/pak.cpp +++ b/librecomp/src/pak.cpp @@ -8,6 +8,16 @@ extern "C" void osPfsInitPak_recomp(uint8_t * rdram, recomp_context* ctx) { ctx->r2 = 1; // PFS_ERR_NOPACK } +extern "C" void osPfsInit_recomp(uint8_t * rdram, recomp_context * ctx) { + ctx->r2 = 1; // PFS_ERR_NOPACK +} + +extern "C" void osPfsIsPlug_recomp(uint8_t * rdram, recomp_context * ctx) { + u8* pattern = _arg<1, u8*>(rdram, ctx); + *pattern = 0; // No controller pak plugged in + ctx->r2 = 0; +} + extern "C" void osPfsFreeBlocks_recomp(uint8_t * rdram, recomp_context * ctx) { ctx->r2 = 1; // PFS_ERR_NOPACK } From fe0dc0b425645a43e5abab244573fdbcec661f97 Mon Sep 17 00:00:00 2001 From: Gabryel-lima Date: Thu, 28 May 2026 13:18:38 -0300 Subject: [PATCH 2/2] Add default return for error handling in error_to_string and wait_for_game_started functions --- librecomp/src/mod_manifest.cpp | 2 ++ librecomp/src/recomp.cpp | 2 ++ 2 files changed, 4 insertions(+) diff --git a/librecomp/src/mod_manifest.cpp b/librecomp/src/mod_manifest.cpp index a96bf2a3..f61bb811 100644 --- a/librecomp/src/mod_manifest.cpp +++ b/librecomp/src/mod_manifest.cpp @@ -1032,4 +1032,6 @@ std::string recomp::mods::error_to_string(CodeModLoadError error) { case CodeModLoadError::UnsupportedApiVersion: return "Mod DLL has an unsupported API version"; } + + return "Unknown code mod load error"; } diff --git a/librecomp/src/recomp.cpp b/librecomp/src/recomp.cpp index ea17675a..13aec1e6 100644 --- a/librecomp/src/recomp.cpp +++ b/librecomp/src/recomp.cpp @@ -704,6 +704,8 @@ bool wait_for_game_started(uint8_t* rdram, recomp_context* context) { case GameStatus::None: return true; } + + return true; } recomp::SaveType recomp::get_save_type() {