fix(cli): use a POSIX path probe in sandbox download

Signed-off-by: Eric Curtin <eric.curtin@docker.com>

Author: ericcurtin

crates/openshell-cli/src/ssh.rs

@@ -1408,6 +1408,19 @@ fn validate_sandbox_source_path(workspace_root: &str, path: &str) -> Result<Stri
     Ok(cleaned)
 }
 
+/// Build the remote probe that prints the workspace root, then the resolved
+/// path if it exists. Uses only POSIX `[` and bare `realpath`, because busybox
+/// `realpath` has no `-e` and treats `--` as a file name.
+fn resolve_probe_command(sandbox_path: &str) -> String {
+    let operand = if sandbox_path.starts_with('/') {
+        sandbox_path.to_string()
+    } else {
+        format!("./{sandbox_path}")
+    };
+    let path = shell_escape(&operand);
+    format!("pwd -P && if [ -e {path} ]; then realpath {path}; fi")
+}
+
 /// Discover the workspace root and resolve every symlink in `sandbox_path` in
 /// one SSH probe, then refuse the result if it lands outside the workspace.
 ///
@@ -1422,10 +1435,7 @@ async fn resolve_sandbox_source_path(
     session: &SshSessionConfig,
     sandbox_path: &str,
 ) -> Result<String> {
-    let resolve_cmd = format!(
-        "pwd -P && realpath -e -- {path}",
-        path = shell_escape(sandbox_path)
-    );
+    let resolve_cmd = resolve_probe_command(sandbox_path);
     let output = ssh_run_capture_stdout(session, &resolve_cmd)
         .await
         .wrap_err_with(|| format!("failed to resolve sandbox source path '{sandbox_path}'"))?;
@@ -3080,6 +3090,30 @@ mod tests {
         assert_eq!(lexical_clean_absolute_path("./a"), None);
     }
 
+    #[test]
+    #[cfg(unix)]
+    fn resolve_probe_command_is_posix_and_resolves_symlinks() {
+        let dir = tempfile::tempdir().unwrap();
+        let root = dir.path().canonicalize().unwrap();
+        fs::write(root.join("-f"), "x").unwrap();
+        std::os::unix::fs::symlink(root.join("-f"), root.join("link")).unwrap();
+        let run = |path: &str| {
+            let output = Command::new("sh")
+                .arg("-c")
+                .arg(resolve_probe_command(path))
+                .current_dir(&root)
+                .output()
+                .unwrap();
+            assert!(output.status.success());
+            String::from_utf8(output.stdout).unwrap()
+        };
+        let cwd = format!("{}\n", root.display());
+        assert!(!resolve_probe_command("a").contains(" -e --"));
+        assert_eq!(run("link"), format!("{cwd}{}/-f\n", root.display()));
+        assert_eq!(run("-f"), format!("{cwd}{}/-f\n", root.display()));
+        assert_eq!(run("missing"), cwd);
+    }
+
     #[test]
     fn validate_sandbox_source_path_accepts_workspace_paths() {
         let workspace_root = "/workspace/project";