Skip to content

Commit 48b2996

Browse files
ci(e2e): trim the host Podman lane to tests tmachine can't run yet
The rust-podman-ci lane ran conformance and 23 e2e/rust binaries. The tmachine e2e-podman row already runs 17 of those binaries, and the tmachine Podman conformance rows run the same conformance tests. Keep only the six binaries no other lane covers: the five wrapper-lane entries in podmanE2eFollowUpBinaries, plus otlp_relay, whose collector cases need the OTLP endpoint the wrapper configures. Skip conformance for the ci set and drop the lane's build-conformance dependency. Closes #5423 Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
1 parent 9e004a7 commit 48b2996

4 files changed

Lines changed: 17 additions & 26 deletions

File tree

‎.github/workflows/branch-e2e.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,16 +373,17 @@ jobs:
373373
image-tag: ${{ github.sha }}
374374
runner: linux-arm64-cpu8
375375

376+
# Runs only the Podman e2e/rust targets that podman-e2e-integration can't run
377+
# yet; see PODMAN_CI_TESTS in e2e/rust/e2e-podman.sh.
376378
podman-e2e:
377-
needs: [pr_metadata, build-binaries, build-conformance, build-images]
379+
needs: [pr_metadata, build-binaries, build-images]
378380
if: needs.pr_metadata.outputs.should_run == 'true' && needs.pr_metadata.outputs.run_core_e2e == 'true'
379381
permissions:
380382
actions: read
381383
contents: read
382384
packages: read
383385
uses: ./.github/workflows/e2e-podman-test.yml
384386
with:
385-
prebuilt-conformance: true
386387
image-tag: ${{ github.sha }}
387388
suite-matrix: >-
388389
[{"suite":"ci","runner":"ubuntu-26.04","podman_major":"5","podman_package_version":"5.7.0+ds2-3build1","conmon_package_version":"2.1.13+ds1-2","cmd":"mise run --no-deps --skip-deps e2e:podman:ci"}]

‎e2e/rust/e2e-podman.sh‎

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -18,33 +18,19 @@ RUN_WITH_GATEWAY_COMMAND="__openshell_run_podman_e2e"
1818
# shellcheck source=e2e/support/conformance.sh
1919
source "${ROOT}/e2e/support/conformance.sh"
2020

21-
# Keep required branch CI on the Podman targets that are known to pass. The
22-
# unfiltered e2e:podman task remains available while the omitted targets are
23-
# stabilized and can be added here.
21+
# Required branch CI runs only the Podman targets that the tmachine e2e-podman
22+
# testsuite can't run yet (see podmanE2eFollowUpBinaries in
23+
# tests/tmachine/artifacts.nix), plus otlp_relay, whose collector cases need the
24+
# OTLP endpoint this script configures. tmachine runs the rest of the Podman
25+
# targets and the conformance suite. Remove each target here once it moves to
26+
# testkit (#5297).
2427
PODMAN_CI_TESTS=(
25-
bypass_detection
26-
ephemeral_cleanup
27-
core_dump_hardening
28-
credential_gating
29-
default_image
3028
driver_config_volume
31-
edge_tunnel_e2e
32-
forward_proxy_graphql_l7
33-
forward_proxy_jsonrpc_l7
34-
forward_proxy_l7_bypass
35-
host_gateway_alias
36-
landlock
37-
live_policy_update
3829
local_driver_token_restart
39-
no_proxy
40-
ocsf_jsonl_conformance
4130
otlp_relay
4231
podman_corporate_proxy
4332
podman_gateway_start
44-
podman_host_gateway
45-
podman_oci_identity
4633
provider_token_exchange
47-
upload_backpressure
4834
)
4935

5036
if [ -n "${E2E_TEST}" ] && [ -n "${E2E_TEST_SET}" ]; then
@@ -79,7 +65,10 @@ if [ "${E2E_TEST}" = "gpu" ] && [ -z "${OPENSHELL_E2E_WORKLOAD_MANIFEST:-}" ] &&
7965
fi
8066

8167
if [ "${1:-}" = "${RUN_WITH_GATEWAY_COMMAND}" ]; then
82-
e2e_run_openshell_conformance "Podman"
68+
# The tmachine Podman rows already run conformance for the ci set.
69+
if [ "${E2E_TEST_SET}" != "ci" ]; then
70+
e2e_run_openshell_conformance "Podman"
71+
fi
8372
if [ "${E2E_FEATURES}" = "e2e-conformance-only" ]; then
8473
echo "::notice::Skipping Rust e2e tests (e2e-conformance-only)"
8574
exit 0

‎tasks/test.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ description = "Run Rust CLI e2e tests against a Podman-backed gateway"
217217
run = "e2e/rust/e2e-podman.sh"
218218

219219
["e2e:podman:ci"]
220-
description = "Run the Podman Rust e2e targets enabled in required branch CI"
220+
description = "Run the Podman Rust e2e targets that only the host Podman lane runs in required branch CI"
221221
run = "OPENSHELL_E2E_PODMAN_TEST_SET=ci e2e/rust/e2e-podman.sh"
222222

223223
["e2e:oidc-pkce"]

‎tests/tmachine/artifacts.nix‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,9 @@ let
8484

8585
# Follow-up: binaries that do not yet run in the rootless tmachine guest. Each
8686
# entry says what it needs. Entries marked "wrapper lane" still run in the
87-
# wrapper-based Podman lane (`mise run e2e:podman:ci`), so they are covered
88-
# there until tmachine provides what they need.
87+
# wrapper-based Podman lane (`mise run e2e:podman:ci`), whose PODMAN_CI_TESTS
88+
# list in e2e/rust/e2e-podman.sh keeps only those binaries plus otlp_relay.
89+
# Update both lists together.
8990
podmanE2eFollowUpBinaries = [
9091
# Needs the caller driver-config settings (`allow_driver_config`,
9192
# `enable_bind_mounts`), which the tmachine gateway does not enable. Wrapper

0 commit comments

Comments
 (0)