You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e3679c4
Browse filesBrowse the repository at this point in the historyBrowse files
Label jobs that have not started as In flight, in the GPU-chart yellow (#141)
## Description
Jobs that have not started yet are easier to read on **Overview**.
- The card's time line reads **In flight since <time>** instead of
"Waiting since".
- Once the job has been sent to a node, the card says **Sent to
<node>**. It used to say "Ran on <node>", which is wrong for a job that
has not run.
- A job that fails or is cancelled before it starts keeps **Sent to
<node>**. The proxy keeps the node on the final event, so the card
decides between "Sent to" and "Ran on" from `startedAt`, not from the
state. `workloadNodeLabel` in `ui/utils/workload-labels.ts` holds that
rule.
- In-flight cards and their connection lines use the GPU chart's yellow
(`#f9b400`). The card corner used the KUI `--color-yellow-500`
(`#d73d00`, an orange), and the lines used `#F5A623`. One `GPU_YELLOW`
constant feeds both the GPU palette and `WORKLOAD_COLOR_MAP`, and the
card passes it to `sheen.css` as `--workload-in-flight-color`, so the
corner and the line cannot drift apart.
- The getting-started guide and the troubleshooting page say a job's
card shows **Sent to** once it has been sent to a node, next to
**Running on** and **Ran on**.
This is the first of three pull requests that make job states accurate.
This one changes copy and color only. The second fixes job identity on
the desktop and event ordering in the broker and proxy. The third makes
In flight and Running reflect engine slots.
## Release intent
<!-- pair-release-intent:v1 -->
### Changelog title
Clearer in-flight jobs
### Changelog body
- Jobs that have not started yet are labeled In flight, and they and
their connection lines use the same yellow as the GPU chart.
- A job's card names the node it was sent to with "Sent to" until the
job starts, including a job that fails or is cancelled before it starts,
instead of "Ran on".
### Bumps
- services: patch
- nvpair-cluster-manager: none
- nvpair-engine-manager: none
- nvpair-errors: none
- nvpair-job-scheduler: none
- nvpair-manual-nodes: none
- nvpair-node-info: none
- nvpair-node-scanner: none
- nvpair-node-settings: none
- nvpair-proxy: none
- nvpair-tui: none
- nvpair-ui-broker: none
- nvpair-workload-manager: none
<!-- /pair-release-intent:v1 -->
`services` is a patch for the user-facing note; no service binary
changes, so every component is `none`.
## Scope
Included: the job card's copy and the in-flight color.
Unchanged:
- **The state itself.** The wire and internal value is still `queued`:
the JSON-RPC payloads, `WorkloadState`, the `workload-card-queued`
class, the Go services, and the specs.
- **When a job counts as in flight.** A non-streaming job still stays in
flight until its response completes. The third pull request changes
that.
- **The terminal UI,** which still prints `queued` in its STATE column.
- **The hidden `workload-badge` bar** on the card, which still gets a
color but is never displayed.
The getting-started screenshots need no update: neither shows an
in-flight card.
## Validation
From `desktop/`, all passing:
- `npm run typecheck`
- `npm run lint`
- `npm run dead-code:check`
- `npm run test:unit` (238 passed, 2 skipped)
- `npm run service-contracts:check`
`node scripts/spdx-headers.mjs` from the repository root also passes.
`tests/modular/workload-card-labels.test.ts` covers the node label for
every state, with and without `startedAt`. It also checks that every
`WORKLOAD_COLOR_MAP` value is six-digit hex and that the in-flight color
is in the GPU palette.
Still to do: run the Inference Demo and confirm that an in-flight card
shows a yellow corner and "In flight since <time>", that its connection
line is yellow, and that the card reads "Sent to <node>" once the job is
dispatched, then "Running on <node>", then "Ran on <node>".
## Risk
Display only: no backend, IPC, or payload change. `WORKLOAD_COLOR_MAP`
values must stay six-digit hex because the connection lines append a
two-digit alpha; the new test enforces it.
## Checklist
- [x] I have read the [Contributing
Guidelines](https://github.com/NVIDIA/Personal-AI-Router/blob/main/CONTRIBUTING.md).
- [x] Every commit is signed off (`git commit -s`), certifying the
[Developer Certificate of Origin](https://developercertificate.org/).
- [x] New or existing tests cover the change.
- [x] Relevant documentation is updated.
- [x] I checked the diff, changed filenames, and commit messages for
credentials, private data, internal URLs, internal issue identifiers,
and generated artifacts.
- [x] I recorded the validation commands and results above.
- [x] I declared version bumps in the release-intent block above.
`services/versions.json` is written by automation — do not edit it by
hand.
---------
Signed-off-by: Chris Kelsey <ckelsey@nvidia.com>
0 commit comments