Repository navigation
Use DiskGraph-owned SamplingOptions for runtime iteration - #449
haoweiyu-kumo wants to merge 3 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Note
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Change Map Design Review | Details from the previous assessment are unavailable. |

Passed checks: 2 passed
-
Check name Status Explanation Pr Size PR size check: the pull request changes 20 files, below the limit of 40. Lines were ignored, as the check requires. Evidence: - The provider-reported target branch is hyu-diskgraph-sampling-plan-datac… Public Resource Access The check applies only to external resource references (URLs, repository locations, package source locations) added or modified by this PR. I diffed the PR's three commits (0d8d8f6, 163ac01, e7775dc… Full details: Pr Size
-
Explanation
PR size check: the pull request changes 20 files, below the limit of 40. Lines were ignored, as the check requires. Evidence: - The provider-reported target branch is hyu-diskgraph-sampling-plan-dataclass. The PR description says the PR is stacked on
#445and rebased onto its head ca82b8f. That commit exists locally. - The PR's own commits are 0d8d8f6, 163ac01, and e7775dc, which sit on top of ca82b8f. -git diff --name-only ca82b8f3..e7775dc3lists 20 files: 17 modified and 3 added. The diffstat is 20 files changed, 628 insertions, 247 deletions. Caveat: the target branch itself was not available locally, so I used the stacked base commit ca82b8f as the base. Against main, the diff is much larger (1725 files). That larger number includes the inherited#445changes. The PR's own diff against its declared base is 20 files, so the check passes.
Full details: Public Resource Access
-
Explanation
The check applies only to external resource references (URLs, repository locations, package source locations) added or modified by this PR. I diffed the PR's three commits (0d8d8f6, 163ac01, e7775dc) against 0d8d8f6^, covering 20 changed files. The added lines contain no http(s) URLs, git+ or git@ references, GitHub/GitLab/Bitbucket links, package index or find-links settings, registry or container image references, or markdown links. The only regex hit was a false positive (
options.target_node_typematched a.tarpattern). The non-Python change is a README.md section that adds an API usage code sample with no links. No removed lines contain external references either. With no added or modified external resource reference, the check passes and no public-access verification is needed. The PR's target branch is not present in this checkout, so I used the first PR commit's parent as the base; that does not change the result because the added-line scan covers the full commit range.
-
Latest assessment: Change Map Design Review
-
Latest assessment: The latest assessment was inconclusive; the previous failure remains unresolved.
Latest explanation: The check reviews the PR conversation comment that starts with
<!-- kumo-pr-change-map -->. This comment is not available to this run. Its text is absent from the checkout, and the only PR-related evidence is the reference in the description to issuecomment-7053655671. No available tool retrieves PR conversation comments. I searched the repository and git refs for the marker and for "Change map". The only hit for the marker is the process note in docs/development/review.md. That note describes the expected comment but does not contain its content. I checked the implementation evidence that the check can use. The repository has a DiskGraph-ownedSamplingOptionsandWeightedSeedSamplingAPI indiskgraph.sampling_options. Callers in the tests and the DataModule useindex.iter(SamplingOptions(...)). The Rust iterator code is unchanged, as the description states. This evidence does not assess the change map. I did not evaluate whether each mapped change is necessary, placed at the right layer, or preserves behavior. I also did not check whether the map states the observed failure, the smallest sufficient change, focused verification, or a stopping condition. The standing previous FAIL has no retained details. I cannot confirm or refute its claims. Missing evidence cannot establish PASS. The check does not define a FAIL condition for an unavailable change-map comment.Latest resolution: Make the
<!-- kumo-pr-change-map -->conversation comment available to the reviewer. Use the comment at #449 (comment) or the current comment with that marker. Then rerun this check. The rerun should also re-review the previous FAIL, which has no retained details. Each mapped change should state the observed failure or release requirement, the inspected existing behavior, the smallest sufficient change, focused verification, and a stopping condition. The reviewer should also check whether the map omits material behavior, such as the explicitNoneseed behavior and the frozen read-only list and dict handling that the description mentions.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Change mapRequirement: make DiskGraph own the typed sampling configuration so the Ray backend can reuse it. The old Python iterator accepted individual keywords; the smallest API change is one Python dataclass plus field forwarding at the existing native boundary, with existing local callers migrated. Rebased onto #445 at ca82b8f; its native-plan and import fixes are retained. Validation: 84 native options/plan/stateless cases, 161 DataModule cases, 6 prediction-selection cases, 3 deterministic explanation-export cases, 1 loaded-model link explanation integration, and 475 targeted experimental PyTorch cases pass across runs. The new regression reproduces 2 failures before the fix; CI passed all 2,630 PyTorch tests and the engine shard. Follow-up static-check fixes pass pinned Ruff 0.17.3 and ty 0.0.23 locally (one existing unused-ignore warning), plus 43 focused tests; Both previously failing GitHub jobs,
|
d92e911 to
163ac01
Compare
Summary
Stacked on #445, rebased onto its latest head
ca82b8f32c.DiskGraph's runtime iterator currently takes a long list of keyword arguments, forcing Ray clients to duplicate that configuration schema. Add DiskGraph-owned frozen Python
SamplingOptionsandWeightedSeedSamplingdataclasses, and change the Python API toindex.iter(options). The existing Rust iterator implementation is unchanged.Migrate the local DataModule, native-anchor adapter, native tests/benchmark helper, and engine regression callers. The two Ray branches are integrated separately. This is an API break: keyword/positional iterator options must move into
SamplingOptions, and weighted seed settings must useWeightedSeedSampling.InheritEngineSeed.DEFAULTpreserves omitted-seed behavior across pickle: an omitted seed inherits the index seed; explicitNonestill disables the seed and fails with shuffle enabled. Dataclass fields are frozen; nested list/dict inputs retain native formats and must remain read-only during iteration. No generic freeze, JSON conversion, or configuration-copy framework is added.The rebase retains #445's CI fixes. Also migrate its new named-neighborhood regression to
SamplingOptionsand fix the remaining engine CI failure: link-prediction explanation graphs now retain predicted items omitted by residual aggregation. A deterministic regression covers zero, one, and two retained neighbors.Change map
File-by-file change map.
Testing Done
git diff --checkpass.Validation uses prepared Python 3.12 CPU dependencies and this checkout's Python source with the matching #445 native build. Existing Torch, pytest configuration, and worker warnings remain. No cloud/cluster benchmarks were run.
CI follow-up (
e7775dc384): the previously failingpyrightandkumo-pytorch-testsjobs both pass on GitHub, including the full PyTorch test suite, Ruff checks, and wheel build. Fixed the formatter expression and narrowed the explanation RHS table name forty. Locally, pinned Ruff 0.17.3, ty 0.0.23 (one existing unused-ignore warning), mypy, and 43 focused regression cases pass.