From 227a68949615bf9c716bd57e287ae41d1f338bf7 Mon Sep 17 00:00:00 2001 From: EylonKrause Date: Wed, 24 Jun 2026 13:50:58 +0300 Subject: [PATCH] fix: propagate error from ncclCudaContextTrack ncclCudaContextTrack captured ncclStrongStreamConstruct's result via NCCLCHECKGOTO but the leave: label hardcoded return ncclSuccess, so a failed stream/event creation was reported as success with a half-initialized context already linked into the global list. Return result so the error propagates. Signed-off-by: EylonKrause --- src/misc/strongstream.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/misc/strongstream.cc b/src/misc/strongstream.cc index 83ab38b76..9f4cd4727 100644 --- a/src/misc/strongstream.cc +++ b/src/misc/strongstream.cc @@ -57,7 +57,7 @@ ncclResult_t ncclCudaContextTrack(struct ncclCudaContext** out) { } leave: *out = p; - return ncclSuccess; + return result; } void ncclCudaContextDrop(struct ncclCudaContext* cxt) {