Change default protocol version to 0 (#419)

Author: bdraco

snitun/client/client_peer.py

@@ -13,7 +13,7 @@
 )
 from ..multiplexer.core import Multiplexer
 from ..multiplexer.crypto import CryptoTransport
-from ..utils import PROTOCOL_VERSION
+from ..utils import DEFAULT_PROTOCOL_VERSION
 from ..utils.asyncio import asyncio_timeout, make_task_waiter_future
 from .connector import Connector
 
@@ -53,7 +53,7 @@ async def start(
         aes_key: bytes,
         aes_iv: bytes,
         throttling: int | None = None,
-        protocol_version: int = PROTOCOL_VERSION,
+        protocol_version: int = DEFAULT_PROTOCOL_VERSION,
     ) -> None:
         """Connect an start ClientPeer."""
         if self._multiplexer:

snitun/utils/__init__.py

@@ -1,5 +1,5 @@
 """Utils & function for implementations."""
 
-from .server import PROTOCOL_VERSION
+from .server import DEFAULT_PROTOCOL_VERSION, PROTOCOL_VERSION
 
-__all__ = ("PROTOCOL_VERSION",)
+__all__ = ("DEFAULT_PROTOCOL_VERSION", "PROTOCOL_VERSION")

snitun/utils/aiohttp_client.py

@@ -14,7 +14,7 @@
 
 from ..client.client_peer import ClientPeer
 from ..client.connector import Connector
-from . import PROTOCOL_VERSION
+from . import DEFAULT_PROTOCOL_VERSION
 from .asyncio import asyncio_timeout
 
 _LOGGER = logging.getLogger(__name__)
@@ -102,7 +102,7 @@ async def connect(
         aes_key: bytes,
         aes_iv: bytes,
         throttling: int | None = None,
-        protocol_version: int = PROTOCOL_VERSION,
+        protocol_version: int = DEFAULT_PROTOCOL_VERSION,
     ) -> None:
         """Connect to SniTun server."""
         if self._client.is_connected:

snitun/utils/server.py

@@ -11,6 +11,7 @@
 MAX_READ_SIZE = 4_096
 MAX_BUFFER_SIZE = 1_024_000
 PROTOCOL_VERSION = 1
+DEFAULT_PROTOCOL_VERSION = 0
 
 
 class TokenData(TypedDict):

tests/utils/test_aiohttp_client.py

@@ -57,7 +57,7 @@ async def test_client_connect_with_protocol_version() -> None:
         mock_client_peer.start.assert_called_once()
         args = mock_client_peer.start.call_args
         assert "protocol_version" in args.kwargs
-        assert args.kwargs["protocol_version"] == 1  # Default PROTOCOL_VERSION
+        assert args.kwargs["protocol_version"] == 0  # DEFAULT_PROTOCOL_VERSION
 
         mock_client_peer.start.reset_mock()
         await client.connect(