From f433984ceb4450bc7a36de053c370bbf40e93a2b Mon Sep 17 00:00:00 2001 From: Bru Date: Tue, 6 Oct 2026 01:29:22 +0200 Subject: [PATCH 1/3] test(nemar): wire Vagaja2023 nemar_id=nm000292, drop from NEMAR_ID_PENDING nm000292 was published 2026-10-05; MOABB's NEMAR reader path verified end-to-end on Voyager (k8s job, provider pinned to 'nemar', no upstream fallback allowed): _download_nemar(subject=3) fetched 15 BIDS files genuinely from data.nemar.org. The deposit's sourcedata/ (pushed directly to main, not a pending PR -- commit caf4a627) is not yet served by NEMAR's own index (a subject-agnostic, no-filter nemar.download(scope='sourcedata') for nm000292 still returns SelectionError: no files matched), so get_data() itself (which depends on the sourcedata mirror for this loader) does not yet succeed through NEMAR; this is a server-side index lag, not a MOABB code or git-content issue, and is expected to resolve once NEMAR's index catches up. No loader scientific change. Test-only + one nemar_id class attribute. Evidence: .pr-audits/w41/N5B-REPORT.md. --- moabb/datasets/vagaja2023.py | 1 + moabb/tests/test_datasets.py | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/moabb/datasets/vagaja2023.py b/moabb/datasets/vagaja2023.py index f2f51483e..1c648caf9 100644 --- a/moabb/datasets/vagaja2023.py +++ b/moabb/datasets/vagaja2023.py @@ -114,6 +114,7 @@ class Vagaja2023(BaseDataset): """ + nemar_id = "nm000292" METADATA = DatasetMetadata( acquisition=AcquisitionMetadata( sampling_rate=500.0, diff --git a/moabb/tests/test_datasets.py b/moabb/tests/test_datasets.py index 19fa2b8c1..68f584c51 100644 --- a/moabb/tests/test_datasets.py +++ b/moabb/tests/test_datasets.py @@ -83,6 +83,10 @@ # nm000233 BCIComp2020UpperLimb, nm000252 Nguyen2017_L, nm000257 Nguyen2017_S, # nm000258 Pressel2016, nm000261 Nguyen2017_V, nm000263 Kaneshiro2015, # nm000269 Mainsah2025_A, nm000273 Lee2019_SSVEP, nm000274 Beetl2021_B. + # Removed on 2026-10-06: nm000292 Vagaja2023 published 2026-10-05 + # (`nemar dataset publish status nm000292` -> published); NEMAR's BIDS + # mirror verified readable end-to-end (k8s job, subject 3 fetched via + # `nemar.download`, no upstream fallback). .pr-audits/w41/N5B-REPORT.md. "Alawieh2025": "nm000312", "Batista2022": "nm000318", "Farabbi2020": "nm000294", @@ -108,7 +112,6 @@ "PoloHortiguela2025": "nm000302", "Shin2022": "nm000315", "Thapa2025": "nm000324", - "Vagaja2023": "nm000292", "WRCC2023_MI_A": "nm000297", "WRCC2023_MI_B": "nm000298", "WRCC2023_MI_C": "nm000299", From 8fa4f1ed54c82078c6ebc6a969b9bab4131b707f Mon Sep 17 00:00:00 2001 From: Bruno Aristimunha Date: Tue, 6 Oct 2026 01:40:21 +0200 Subject: [PATCH 2/3] Shorten NEMAR_ID_PENDING removal note --- moabb/tests/test_datasets.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/moabb/tests/test_datasets.py b/moabb/tests/test_datasets.py index 68f584c51..88c9f363d 100644 --- a/moabb/tests/test_datasets.py +++ b/moabb/tests/test_datasets.py @@ -83,10 +83,7 @@ # nm000233 BCIComp2020UpperLimb, nm000252 Nguyen2017_L, nm000257 Nguyen2017_S, # nm000258 Pressel2016, nm000261 Nguyen2017_V, nm000263 Kaneshiro2015, # nm000269 Mainsah2025_A, nm000273 Lee2019_SSVEP, nm000274 Beetl2021_B. - # Removed on 2026-10-06: nm000292 Vagaja2023 published 2026-10-05 - # (`nemar dataset publish status nm000292` -> published); NEMAR's BIDS - # mirror verified readable end-to-end (k8s job, subject 3 fetched via - # `nemar.download`, no upstream fallback). .pr-audits/w41/N5B-REPORT.md. + # Removed on 2026-10-06 (published): nm000292 Vagaja2023. "Alawieh2025": "nm000312", "Batista2022": "nm000318", "Farabbi2020": "nm000294", From 3b9cf328a7e4275a05b5a06105078698d674df51 Mon Sep 17 00:00:00 2001 From: Bruno Aristimunha Date: Tue, 6 Oct 2026 01:40:42 +0200 Subject: [PATCH 3/3] Drop private evidence path from NEMAR_ID_PENDING comment --- moabb/tests/test_datasets.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/moabb/tests/test_datasets.py b/moabb/tests/test_datasets.py index 88c9f363d..479a9ec81 100644 --- a/moabb/tests/test_datasets.py +++ b/moabb/tests/test_datasets.py @@ -76,8 +76,7 @@ NEMAR_ID_PENDING = { # Removed on 2026-10-05: these 15 deposits were published on NEMAR and are # anonymously reachable (fresh clone + annexed-EDF HTTP 200 against - # https://nemar.s3.us-east-2.amazonaws.com//objects/). Evidence: - # .pr-audits/w41/p2-evidence/anon-report.tsv. + # https://nemar.s3.us-east-2.amazonaws.com//objects/). # nm000174 AguileraRodriguez2025, nm000177 Kumar2024, nm000178 BNCI2020_001, # nm000184 BCIComp2020WalkingERP, nm000220 Beetl2021_A, nm000224 Nguyen2017_SL, # nm000233 BCIComp2020UpperLimb, nm000252 Nguyen2017_L, nm000257 Nguyen2017_S,