Build: Move defaults for detected build properties

tonygermano · tonygermano · commit 2872ebc337fa · 2026-01-10T17:10:53.000-05:00
The default values for the following properties are now specified in the
.properties files in the event that git is unavailable when building the
project:

- git.commit.timestamp
- git.commit.hash
- git.commit.name

The default properties have the same names as the properties above with a
`.default` suffix.

Signed-off-by: Tony Germano &lt;tony@germano.name&gt;
diff --git a/client/ant-build.xml b/client/ant-build.xml
@@ -14,7 +14,7 @@
 		</path>
 
 		<!-- Set to default if not set globally -->
-		<property name="git.commit.timestamp" value="2025-03-25T22:28:08.664Z" />
+		<property name="git.commit.timestamp" value="${git.commit.timestamp.default}" />
 
 		<mkdir dir="${logs}" />
 
diff --git a/client/build.properties b/client/build.properties
@@ -11,4 +11,6 @@ logs=${basedir}/logs
 dist=${basedir}/dist
 
 # jars
-client.jar=mirth-client.jar
+client.jar=mirth-client.jar
+
+git.commit.timestamp.default=1999-01-01T00:00:00.000Z
diff --git a/command/build.properties b/command/build.properties
@@ -12,4 +12,6 @@ server=${basedir}/../server
 
 # jars
 cli.jar=mirth-cli.jar
-cli-launcher.jar=mirth-cli-launcher.jar
+cli-launcher.jar=mirth-cli-launcher.jar
+
+git.commit.timestamp.default=1999-01-01T00:00:00.000Z
diff --git a/command/build.xml b/command/build.xml
@@ -7,7 +7,7 @@
 		</path>
 
 		<!-- Set to default if not set globally -->
-		<property name="git.commit.timestamp" value="2025-03-25T22:28:08.664Z" />
+		<property name="git.commit.timestamp" value="${git.commit.timestamp.default}" />
 	</target>
 
 	<target name="clean" depends="init">
diff --git a/donkey/build.properties b/donkey/build.properties
@@ -18,3 +18,5 @@ model.jar=donkey-model.jar
 setup=${basedir}/setup
 setup.lib=${setup}/lib
 setup.docs=${setup}/docs
+
+git.commit.timestamp.default=1999-01-01T00:00:00.000Z
diff --git a/donkey/build.xml b/donkey/build.xml
@@ -8,7 +8,7 @@
 		</path>
 
 		<!-- Set to default if not set globally -->
-		<property name="git.commit.timestamp" value="2025-03-25T22:28:08.664Z" />
+		<property name="git.commit.timestamp" value="${git.commit.timestamp.default}" />
 	</target>
 	
 	<target name="clean" depends="init">
diff --git a/generator/build.properties b/generator/build.properties
@@ -9,4 +9,6 @@ vocab.src=${vocab}/src
 vocab.classes=${vocab}/classes
 vocab.dist=${vocab}/dist
 vocab.version=1.2
-vocab.jar=mirth-vocab-${vocab.version}.jar
+vocab.jar=mirth-vocab-${vocab.version}.jar
+
+git.commit.timestamp.default=1999-01-01T00:00:00.000Z
diff --git a/generator/build.xml b/generator/build.xml
@@ -7,7 +7,7 @@
 		</path>
 
 		<!-- Set to default if not set globally -->
-		<property name="git.commit.timestamp" value="2025-03-25T22:28:08.664Z" />
+		<property name="git.commit.timestamp" value="${git.commit.timestamp.default}" />
 	</target>
 
 	<target name="clean" depends="init">
diff --git a/manager/ant-build.xml b/manager/ant-build.xml
@@ -12,7 +12,7 @@
 		</path>
 
 		<!-- Set to default if not set globally -->
-		<property name="git.commit.timestamp" value="2025-03-25T22:28:08.664Z" />
+		<property name="git.commit.timestamp" value="${git.commit.timestamp.default}" />
 
 		<mkdir dir="${logs}" />
 	</target>
diff --git a/manager/build.properties b/manager/build.properties
@@ -7,4 +7,6 @@ dist=${basedir}/dist
 dist.source=${dist}/source
 
 # jars
-manager.jar=mirth-manager-launcher.jar
+manager.jar=mirth-manager-launcher.jar
+
+git.commit.timestamp.default=1999-01-01T00:00:00.000Z
diff --git a/server/build.properties b/server/build.properties
@@ -49,3 +49,5 @@ setup.docs=${setup}/docs
 dist=${basedir}/dist
 dist.extensions=${dist}/extensions
 test.dist=${basedir}/testdist
+
+git.commit.timestamp.default=1999-01-01T00:00:00.000Z
diff --git a/server/build.xml b/server/build.xml
@@ -18,7 +18,7 @@
 		</path>
 
 		<!-- Set to default if not set globally -->
-		<property name="git.commit.timestamp" value="2025-03-25T22:28:08.664Z" />
+		<property name="git.commit.timestamp" value="${git.commit.timestamp.default}" />
 
 		<!-- connectors -->
 		<property name="connectors.jms" value="${extensions}/jms" />
diff --git a/server/mirth-build.properties b/server/mirth-build.properties
@@ -5,3 +5,8 @@ webadmin=../webadmin
 manager=../manager
 cli=../command
 version=4.5.2
+
+# set default values if git is unavailable
+git.commit.timestamp.default=1999-01-01T00:00:00.000Z
+git.commit.hash.default=
+git.commit.name.default=unavailable
diff --git a/server/mirth-build.xml b/server/mirth-build.xml
@@ -39,19 +39,19 @@
 		-->
 
 		<!-- Get the timestamp of the current git commit in ISO-8601 format-->
-		<exec-with-default executable="git" property="git.commit.timestamp" default="2025-03-25T22:28:08.664Z">
+		<exec-with-default executable="git" property="git.commit.timestamp" default="${git.commit.timestamp.default}">
 			<args><arg line="log -1 --pretty=%cI"/></args>
 		</exec-with-default>
 		<echo>Using git.commit.timestamp of [${git.commit.timestamp}]</echo>
 
 		<!-- Get the long hash of the current git commit -->
-		<exec-with-default executable="git" property="git.commit.hash" default="">
+		<exec-with-default executable="git" property="git.commit.hash" default="${git.commit.hash.default}">
 			<args><arg line="rev-parse HEAD"/></args>
 		</exec-with-default>
 		<echo>Using git.commit.hash of [${git.commit.hash}]</echo>
 
 		<!-- Get the human readable name of the current git commit for build version -->
-		<exec-with-default executable="git" property="git.commit.name" default="unavailable">
+		<exec-with-default executable="git" property="git.commit.name" default="${git.commit.name.default}">
 			<args>
 				<arg value="describe" />
 				<arg value="--match" />
