fix: refactor AuditLogFormatterFactory

Resolve child entity formatter using collection ClassMetadata (getTypeClass)
instead of accessing elements/counting the collection, preventing unintended
hydration and large per-request memory growth.

Author: smarcet

app/Audit/AuditLogFormatterFactory.php

@@ -17,7 +17,9 @@
 use App\Audit\ConcreteFormatters\EntityDeletionAuditLogFormatter;
 use App\Audit\ConcreteFormatters\EntityUpdateAuditLogFormatter;
 use App\Audit\Interfaces\IAuditStrategy;
-
+use Doctrine\ORM\PersistentCollection;
+use Illuminate\Support\Facades\Log;
+use Doctrine\ORM\Mapping\ClassMetadata;
 class AuditLogFormatterFactory implements IAuditLogFormatterFactory
 {
 
@@ -34,14 +36,68 @@ public function make(AuditContext $ctx, $subject, $eventType): ?IAuditLogFormatt
         $formatter = null;
         switch ($eventType) {
             case IAuditStrategy::EVENT_COLLECTION_UPDATE:
-                $child_entity = null;
-                if (count($subject) > 0) {
-                    $child_entity = $subject[0];
-                }
-                if (is_null($child_entity) && isset($subject->getSnapshot()[0]) && count($subject->getSnapshot()) > 0) {
-                    $child_entity = $subject->getSnapshot()[0];
+                $child_entity_formatter = null;
+
+                if ($subject instanceof PersistentCollection) {
+                    $targetEntity = null;
+                    Log::debug
+                    (
+                        sprintf
+                        (
+                            "AuditLogFormatterFactory::make subject is a PersistentCollection isInitialized %b ?",
+                            $subject->isInitialized()
+                        )
+                    );
+                    if (method_exists($subject, 'getTypeClass')) {
+                        $type = $subject->getTypeClass();
+                        // Your log shows this is ClassMetadata
+                        if ($type instanceof ClassMetadata) {
+                            // Doctrine supports either getName() or public $name
+                            $targetEntity = method_exists($type, 'getName') ? $type->getName() : ($type->name ?? null);
+                        } elseif (is_string($type)) {
+                            $targetEntity = $type;
+                        }
+                        Log::debug("AuditLogFormatterFactory::make getTypeClass targetEntity {$targetEntity}");
+                    }
+                    elseif (method_exists($subject, 'getMapping')) {
+                        $mapping = $subject->getMapping();
+                        $targetEntity = $mapping['targetEntity'] ?? null;
+                        Log::debug("AuditLogFormatterFactory::make getMapping targetEntity {$targetEntity}");
+                    } else {
+                        // last-resort: read private association metadata (still no hydration)
+                        $ref = new \ReflectionObject($subject);
+                        foreach (['association', 'mapping', 'associationMapping'] as $propName) {
+                            if ($ref->hasProperty($propName)) {
+                                $prop = $ref->getProperty($propName);
+                                $prop->setAccessible(true);
+                                $mapping = $prop->getValue($subject);
+                                $targetEntity = $mapping['targetEntity'] ?? null;
+                                if ($targetEntity) break;
+                            }
+                        }
+                    }
+
+                    if ($targetEntity) {
+                        // IMPORTANT: build formatter WITHOUT touching collection items
+                        $child_entity_formatter = ChildEntityFormatterFactory::build($targetEntity);
+                    }
+                    Log::debug
+                    (
+                        sprintf
+                        (
+                            "AuditLogFormatterFactory::make subject is a PersistentCollection isInitialized %b ? ( final )",
+                            $subject->isInitialized()
+                        )
+                    );
+                } elseif (is_array($subject)) {
+                    $child_entity = $subject[0] ?? null;
+                    $child_entity_formatter = $child_entity ? ChildEntityFormatterFactory::build($child_entity) : null;
+                } elseif (is_object($subject) && method_exists($subject, 'getSnapshot')) {
+                    $snap = $subject->getSnapshot(); // only once
+                    $child_entity = $snap[0] ?? null;
+                    $child_entity_formatter = $child_entity ? ChildEntityFormatterFactory::build($child_entity) : null;
                 }
-                $child_entity_formatter = $child_entity != null ? ChildEntityFormatterFactory::build($child_entity) : null;
+
                 $formatter = new EntityCollectionUpdateAuditLogFormatter($child_entity_formatter);
                 break;
             case IAuditStrategy::EVENT_ENTITY_CREATION:
@@ -65,6 +121,7 @@ public function make(AuditContext $ctx, $subject, $eventType): ?IAuditLogFormatt
                 }
                 break;
         }
+        if ($formatter === null) return null;
         $formatter->setContext($ctx);
         return $formatter;
     }
@@ -73,7 +130,7 @@ private function getFormatterByContext(object $subject, string $event_type, Audi
     {
         $class = get_class($subject);
         $entity_config = $this->config['entities'][$class] ?? null;
-        
+
         if (!$entity_config) {
             return null;
         }

app/Audit/ConcreteFormatters/ChildEntityFormatters/ChildEntityFormatterFactory.php

@@ -16,25 +16,25 @@
  **/
 
 use Illuminate\Support\Facades\Log;
-use ReflectionClass;
 
 /**
  * Class ChildEntityFormatterFactory
  * @package App\Audit\ConcreteFormatters\ChildEntityFormatter
  */
 class ChildEntityFormatterFactory {
 
-    public static function build($entity): ?IChildEntityAuditLogFormatter {
+    public static function build(object|string $entity): ?IChildEntityAuditLogFormatter {
         try {
-            $class_name = (new ReflectionClass($entity))->getShortName();
-            $class_name = "App\\Audit\\ConcreteFormatters\\ChildEntityFormatters\\{$class_name}AuditLogFormatter";
-            if(class_exists($class_name)) {
-                return new $class_name();
-            }
-            return null;
-        } catch (\ReflectionException $e) {
+            $short = is_string($entity)
+                ? substr(ltrim($entity, '\\'), strrpos(ltrim($entity, '\\'), '\\') + 1)
+                : (new \ReflectionClass($entity))->getShortName();
+            Log::debug("ChildEntityFormatterFactory::build short {$short}");
+            $class = "App\\Audit\\ConcreteFormatters\\ChildEntityFormatters\\{$short}AuditLogFormatter";
+            return class_exists($class) ? new $class() : null;
+
+        } catch (\Throwable $e) {
             Log::error($e);
             return null;
         }
     }
-}
+}