diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6f8f64c144..6ecbefed46 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -3169,7 +3169,7 @@ jobs: - name: Run Effect fixture run: | cd tests/release/packages/effect-basic - PERRY_EFFECT_BASIC_ADVISORY=1 PERRY_BIN="$GITHUB_WORKSPACE/target/release/perry" bash fixture.sh + PERRY_BIN="$GITHUB_WORKSPACE/target/release/perry" bash fixture.sh - name: Upload Effect fixture logs if: always() diff --git a/tests/release/packages/README.md b/tests/release/packages/README.md index 89fa7a9a64..0e47787779 100644 --- a/tests/release/packages/README.md +++ b/tests/release/packages/README.md @@ -77,8 +77,8 @@ The harness defines its own pass/fail/skip totals; downstream consumers The `effect-basic` and `ink-link-smoke` fixtures also have named CI jobs in `.github/workflows/test.yml`. They run on release tags, on manual dispatch with `run_extended_tests=true`, and on PRs with the `run-extended-tests` label. The -Effect job opts into a currently advisory compile/run signal with -`PERRY_EFFECT_BASIC_ADVISORY=1`; the default tier-3 sweep records it as SKIP so -known Effect end-to-end gaps do not block unrelated package releases. The Ink -job intentionally stops at compile/link plus symbol inspection; end-to-end Ink -rendering remains tracked separately from the release fixture contract. +Effect fixture compiles and runs in both the default tier-3 sweep and its named +job. The named job remains advisory, matching the tier-3 convention, so broader +Effect end-to-end gaps do not block unrelated changes. The Ink job intentionally +stops at compile/link plus symbol inspection; end-to-end Ink rendering remains +tracked separately from the release fixture contract. diff --git a/tests/release/packages/effect-basic/fixture.sh b/tests/release/packages/effect-basic/fixture.sh index 672c31bae9..875257cbc6 100755 --- a/tests/release/packages/effect-basic/fixture.sh +++ b/tests/release/packages/effect-basic/fixture.sh @@ -14,7 +14,7 @@ fi # instead of skipping behind an opt-in flag. The CI job stays advisory # (`continue-on-error: true`) per the tier-3 convention. The historical # `PERRY_EFFECT_BASIC_ADVISORY=1` gate (added in #4391 when Effect reliably -# failed) is gone; the env var is now a harmless no-op. +# failed) was removed in #6572. fixture_setup "$NAME" || exit 1 fixture_compile_run_diff "$NAME"