Skip to content

Conversation

@joos-too
Copy link
Contributor

@joos-too joos-too commented Nov 27, 2025

I added the german location names in location_names.csv as well as location_area_prose.csv.
The names were retrieved via the german pokemon wiki Pokewiki.de and manually checked.

I didn't add all the numbered entries for f.E. Space World. The numbers differed between english and french, which confused me.

@Naramsim
Copy link
Member

Thanks a lot for the PR! We really appreciate contributions!

Copy link
Member

@Naramsim Naramsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked some location and all seems good, thanks again!

@joos-too
Copy link
Contributor Author

Thanks a lot for the PR! We really appreciate contributions!

Glad to contribute. Thanks for the great API!

@Naramsim Naramsim merged commit 2a53ef6 into PokeAPI:master Nov 27, 2025
9 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@joos-too joos-too deleted the add-german-location-names branch November 27, 2025 14:28
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Nov 27, 2025
@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants