fix(promql): represent set-op default matching as ignoring([]), not on([]) (#68) (#74)

The parser attaches a default modifier to every `and`/`or`/`unless`, whose
`matching` is `None`. `walk_binary` mapped that to `VectorMatch{On, []}` —
byte-identical to an explicit `on()`. So `a and b` and `a and on() b` lowered
to the same tree, and the default "match on all shared labels" was
misrepresented as "match on the empty label set".

The default is exactly `ignoring([])` (ignore no labels ⇒ match on all shared
labels). Map the `None` arm to `Ignoring([])` instead:
  - `a and b`            → Ignoring([])
  - `a and on() b`       → On([])        (now distinct)
  - `a and ignoring() b` → Ignoring([])  (now correctly equal to default)

Added `set_op_default_match_is_ignoring_empty_not_on_empty` (distinct-vs-on,
equal-to-ignoring). Full workspace suite green; clippy --all-targets clean.

Co-authored-by: zz_y <zz_y@node0.zz-y-308294.softmeasure-pg0.clemson.cloudlab.us>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: 3 people

crates/frontend-promql/src/promql.rs

@@ -388,7 +388,14 @@ fn walk_binary(bin: &BinaryExpr) -> Result<L2> {
         let (kind, labels) = match &m.matching {
             Some(LabelModifier::Include(ls)) => (VectorMatchKind::On, ls.labels.clone()),
             Some(LabelModifier::Exclude(ls)) => (VectorMatchKind::Ignoring, ls.labels.clone()),
-            None => (VectorMatchKind::On, vec![]),
+            // No explicit `on(…)`/`ignoring(…)` — the parser attaches a default
+            // modifier to every set op (`and`/`or`/`unless`). The default is
+            // "match on all shared labels", which is exactly `ignoring([])`
+            // (ignore no labels). Representing it as `Ignoring([])` — not
+            // `On([])` — keeps it distinct from an explicit `on()` (match on the
+            // empty label set) while making it correctly equal to an explicit
+            // `ignoring()` (issue #68).
+            None => (VectorMatchKind::Ignoring, vec![]),
         };
         let grouping = match &m.card {
             VectorMatchCardinality::ManyToOne(ls) => Some(VectorGrouping {

crates/frontend-promql/tests/promql_equivalence.rs

@@ -141,6 +141,20 @@ fn rate_and_irate_share_the_same_intent() {
     assert_equiv(&["rate(m[5m])", "irate(m[5m])"]);
 }
 
+#[test]
+fn set_op_default_match_is_ignoring_empty_not_on_empty() {
+    // Issue #68. A set op's *default* matching ("match on all shared labels") is
+    // `ignoring([])`, NOT `on([])`. So:
+    //   - default `a and b` must stay DISTINCT from explicit `a and on() b`
+    //     (which matches on the empty label set), and
+    //   - default `a and b` must EQUAL explicit `a and ignoring() b`
+    //     (ignore no labels ⇒ match on all shared labels).
+    assert_distinct("a and b", "a and on() b");
+    assert_distinct("a or b", "a or on() b");
+    assert_equiv(&["a and b", "a and ignoring() b"]);
+    assert_equiv(&["a unless b", "a unless ignoring() b"]);
+}
+
 // ─────────────────────────────────────────────────────────────────────────────
 // 4. Distinct semantics we cannot faithfully represent are REJECTED, not
 //    silently merged into a wrong intent. (Each previously mislowered.)