Repository navigation
Commit f9458d6
feat(core): route tabular GROUP BY through positional Aggregate.by (key in schema)
The single-aggregate fused path wraps GROUP BY keys in a name-based Partition
(the PromQL streaming-sketch canonical shape) whose output schema is the child's
— so the group key is not an output column. That's correct for time series but
wrong for SQL, where `SELECT k, agg(...) GROUP BY k` projects `k`.
The fused path is now gated on a *time-series* leaf (`relational::leaf_is_tabular`
= the leftmost Source carries a resolved schema, i.e. Source::Table). Tabular
single-agg GROUP BY falls through to the positional `Aggregate.by` path, so the
key lands in the output schema and the enclosing SELECT projection resolves it.
PromQL's fused-Partition shape is unchanged.
- relational: factor out `leaf_source`; add `leaf_is_tabular`; `source_name` now
delegates to `leaf_source`.
Test: `SELECT service, SUM(bytes) GROUP BY service` → Aggregate.by=[1],
Sum{col:3}, and the root projection schema is [service:Utf8, sum:Int64]. 111
tests green, clippy -D warnings clean, fmt clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent d96e032 commit f9458d6
3 files changed
Lines changed: 51 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
227 | | - | |
| 226 | + | |
| 227 | + | |
228 | 228 | | |
229 | | - | |
| 229 | + | |
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
240 | | - | |
| 239 | + | |
| 240 | + | |
241 | 241 | | |
242 | 242 | | |
243 | | - | |
244 | | - | |
| 243 | + | |
| 244 | + | |
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
248 | 262 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
137 | 158 | | |
138 | 159 | | |
139 | 160 | | |
| |||
0 commit comments