Skip to content

Commit 09e4629

Browse files
zzylolclaude
andauthored
refactor: sketch-core retirement + branch-pin cleanup + elastic DSL test fix (#309)
* Revert "Revert "refactor: retire sketch-core mirror (#307)" (#310)" This reverts commit ea723f4. * chore: track asap_sketchlib main + fix elastic DSL quantile assert After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 82ad5da commit 09e4629

30 files changed

Lines changed: 187 additions & 3226 deletions

‎Cargo.lock‎

Lines changed: 73 additions & 180 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
[workspace]
22
resolver = "2"
33
members = [
4-
"asap-common/sketch-core",
54
"asap-common/dependencies/rs/promql_utilities",
65
"asap-common/dependencies/rs/sql_utilities",
76
"asap-common/dependencies/rs/elastic_dsl_utilities",
@@ -32,7 +31,6 @@ promql-parser = "0.5.0"
3231
tokio = { version = "1.0", features = ["full"] }
3332

3433
# Internal crates
35-
sketch-core = { path = "asap-common/sketch-core" }
3634
promql_utilities = { path = "asap-common/dependencies/rs/promql_utilities" }
3735
sql_utilities = { path = "asap-common/dependencies/rs/sql_utilities" }
3836
asap_types = { path = "asap-common/dependencies/rs/asap_types" }

‎asap-common/sketch-core/Cargo.toml‎

Lines changed: 0 additions & 16 deletions
This file was deleted.

‎asap-common/sketch-core/report.md‎

Lines changed: 0 additions & 125 deletions
This file was deleted.

0 commit comments

Comments
 (0)