fixed clippy

Author: milindsrivastava1997

asap-planner-rs/src/lib.rs

@@ -140,10 +140,8 @@ impl PlannerOutput {
                                         for key in
                                             ["read_count_threshold", "num_aggregates_to_retain"]
                                         {
-                                            if let Some(v) = agg.get(key) {
-                                                if let YamlValue::Number(n) = v {
-                                                    return n.as_u64();
-                                                }
+                                            if let Some(YamlValue::Number(n)) = agg.get(key) {
+                                                return n.as_u64();
                                             }
                                         }
                                     }

asap-planner-rs/src/planner/logics.rs

@@ -250,10 +250,30 @@ pub fn get_cleanup_param(
     Ok(result)
 }
 
+pub fn set_subpopulation_labels(
+    statistic: Statistic,
+    aggregation_type: &str,
+    subpopulation_labels: &KeyByLabelNames,
+    rollup_labels: &mut KeyByLabelNames,
+    grouping_labels: &mut KeyByLabelNames,
+    aggregated_labels: &mut KeyByLabelNames,
+) {
+    // rollup is set by caller before calling this function
+    let _ = rollup_labels; // not modified here
+    if does_precompute_operator_support_subpopulations(statistic, aggregation_type) {
+        *grouping_labels = KeyByLabelNames::empty();
+        *aggregated_labels = subpopulation_labels.clone();
+    } else {
+        *grouping_labels = subpopulation_labels.clone();
+        *aggregated_labels = KeyByLabelNames::empty();
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;
     use crate::planner::patterns::build_patterns;
+
     use promql_utilities::ast_matching::PromQLMatchResult;
     use promql_utilities::query_logics::enums::QueryPatternType;
 
@@ -381,22 +401,3 @@ mod tests {
         assert!(result.is_err());
     }
 }
-
-pub fn set_subpopulation_labels(
-    statistic: Statistic,
-    aggregation_type: &str,
-    subpopulation_labels: &KeyByLabelNames,
-    rollup_labels: &mut KeyByLabelNames,
-    grouping_labels: &mut KeyByLabelNames,
-    aggregated_labels: &mut KeyByLabelNames,
-) {
-    // rollup is set by caller before calling this function
-    let _ = rollup_labels; // not modified here
-    if does_precompute_operator_support_subpopulations(statistic, aggregation_type) {
-        *grouping_labels = KeyByLabelNames::empty();
-        *aggregated_labels = subpopulation_labels.clone();
-    } else {
-        *grouping_labels = subpopulation_labels.clone();
-        *aggregated_labels = KeyByLabelNames::empty();
-    }
-}